Changeset 280654 in webkit

Timestamp:

Aug 4, 2021, 1:28:16 PM (5 years ago)

Author:

magomez@igalia.com

Message:

[GTK][WPE] Elliptic radial gradients are not working
​https://bugs.webkit.org/show_bug.cgi?id=228771

Reviewed by Žan Doberšek.

Transform the radial circular gradients using the aspect ratio to convert
them into the appropriate elliptic gradients.

• platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::createPattern):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cairo/GradientCairo.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-04  Miguel Gomez  <magomez@igalia.com>
+
+        [GTK][WPE] Elliptic radial gradients are not working
+        https://bugs.webkit.org/show_bug.cgi?id=228771
+
+        Reviewed by Žan Doberšek.
+
+        Transform the radial circular gradients using the aspect ratio to convert
+        them into the appropriate elliptic gradients.
+
+        * platform/graphics/cairo/GradientCairo.cpp:
+        (WebCore::Gradient::createPattern):
+
 2021-08-04  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/platform/graphics/cairo/GradientCairo.cpp

@@ -196 +196 @@
 RefPtr<cairo_pattern_t> Gradient::createPattern(float globalAlpha, const AffineTransform& gradientSpaceTransform)
 {
+    cairo_matrix_t matrix = toCairoMatrix(gradientSpaceTransform);
+    cairo_matrix_invert(&matrix);
+
     auto gradient = WTF::switchOn(m_data,
         [&] (const LinearData& data) {
@@ -207 +210 @@
             for (auto& stop : stops())
                 addColorStopRGBA(gradient.get(), stop, globalAlpha);
+
+            if (data.aspectRatio != 1) {
+                cairo_matrix_translate(&matrix, data.point0.x(), data.point0.y());
+                cairo_matrix_scale(&matrix, 1.0, data.aspectRatio);
+                cairo_matrix_translate(&matrix, -data.point0.x(), -data.point0.y());
+            }
+
             return gradient;
         },
@@ -231 +241 @@
     }
 
-    cairo_matrix_t matrix = toCairoMatrix(gradientSpaceTransform);
-    cairo_matrix_invert(&matrix);
     cairo_pattern_set_matrix(gradient.get(), &matrix);