Changeset 280655 in webkit

Timestamp:

Aug 4, 2021, 1:44:38 PM (5 years ago)

Author:

Jonathan Bedard

Message:

[check-github-mirror-integrity] Compare current time to canonical time
​https://bugs.webkit.org/show_bug.cgi?id=228787
<rdar://problem/81524499>

Reviewed by Aakash Jain.

• Scripts/check-github-mirror-integrity: If the mirror isn't in line with the canonical repository, we should

check against the current time, not the time of last commit on the mirror.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/check-github-mirror-integrity (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-08-04  Jonathan Bedard  <jbedard@apple.com>
+
+        [check-github-mirror-integrity] Compare current time to canonical time
+        https://bugs.webkit.org/show_bug.cgi?id=228787
+        <rdar://problem/81524499>
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/check-github-mirror-integrity: If the mirror isn't in line with the canonical repository, we should
+        check against the current time, not the time of last commit on the mirror.
+
 2021-08-03  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Tools/Scripts/check-github-mirror-integrity

@@ -25 +25 @@
 import os
 import sys
+import time
 
 from webkitpy import webkitscmpy
@@ -42 +43 @@
         return 0
 
-    if mirror_tip.timestamp >= canonical_tip.timestamp - 5 * 60 and mirror_tip.identifier == canonical_tip.identifier - 1:
+    if time.time() >= canonical_tip.timestamp - 5 * 60 and mirror_tip.identifier == canonical_tip.identifier - 1:
         print('GitHub is 1 commit behind svn.webkit.org. This is ok.')
         print(f'HEAD commit on GitHub {mirror_tip} slightly behind HEAD commit on svn.webkit.org {canonical_tip}')