Changeset 280672 in webkit

Timestamp:

Aug 4, 2021, 4:55:13 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Bifurcated RemoteLayerBackingStore zooms in every time it repaints
​https://bugs.webkit.org/show_bug.cgi?id=228798

Reviewed by Sam Weinig.

• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::display):
If applying the scale/flip workaround manually, we need to save the
GraphicsContext state, or it leaks between paints.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-08-04  Tim Horton  <timothy_horton@apple.com>
+
+        Bifurcated RemoteLayerBackingStore zooms in every time it repaints
+        https://bugs.webkit.org/show_bug.cgi?id=228798
+
+        Reviewed by Sam Weinig.
+
+        * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+        (WebKit::RemoteLayerBackingStore::display):
+        If applying the scale/flip workaround manually, we need to save the
+        GraphicsContext state, or it leaks between paints.
+
 2021-08-04  Jean-Yves Avenard  <jya@apple.com>
 

trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm

@@ -288 +288 @@
         // FIXME: Remove this when <rdar://problem/80487697> is fixed.
         static std::optional<bool> needsMissingFlipWorkaround;
+        WebCore::GraphicsContextStateSaver workaroundStateSaver(displayListContext, false);
         if (!needsMissingFlipWorkaround) {
             id defaultValue = [[NSUserDefaults standardUserDefaults] objectForKey:@"WebKitNeedsWorkaroundFor80487697"];
@@ -293 +294 @@
         }
         if (needsMissingFlipWorkaround.value()) {
+            workaroundStateSaver.save();
             displayListContext.scale(WebCore::FloatSize(m_scale, -m_scale));
             displayListContext.translate(0, -m_size.height());