Changeset 280686 in webkit

Timestamp:

Aug 5, 2021, 8:02:38 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Fix warning in HTTPParsers.parseStructuredFieldValue
​https://bugs.webkit.org/show_bug.cgi?id=228815

Patch by Rob Buis <​rbuis@igalia.com> on 2021-08-05
Reviewed by Sam Weinig.

UChar is unsigned, so it is not needed to check that it is
zewro or greater.

• platform/network/HTTPParsers.cpp:

(WebCore::parseStructuredFieldValue):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/HTTPParsers.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-05  Rob Buis  <rbuis@igalia.com>
+
+        Fix warning in HTTPParsers.parseStructuredFieldValue
+        https://bugs.webkit.org/show_bug.cgi?id=228815
+
+        Reviewed by Sam Weinig.
+
+        UChar is unsigned, so it is not needed to check that it is
+        zewro or greater.
+
+        * platform/network/HTTPParsers.cpp:
+        (WebCore::parseStructuredFieldValue):
+
 2021-08-05  Imanol Fernandez  <ifernandez@igalia.com>
 

trunk/Source/WebCore/platform/network/HTTPParsers.cpp

@@ -649 +649 @@
                         value = valueBuilder.toString();
                         break;
-                    } else if ((header[index] >= 0x00 && header[index] <= 0x1F) || (header[index] >= 0x7F && header[index] <= 0xFF)) // Not in VCHAR or SP.
+                    } else if (header[index] <= 0x1F || (header[index] >= 0x7F && header[index] <= 0xFF)) // Not in VCHAR or SP.
                         return std::nullopt;
                     else