Changeset 280700 in webkit

Timestamp:

Aug 5, 2021, 11:03:13 AM (5 years ago)

Author:

Alan Bujtas

Message:

Document::isLayoutTimerActive should read isLayoutPending
​https://bugs.webkit.org/show_bug.cgi?id=228835

Reviewed by Antti Koivisto.

Callers of this function curious about whether there's a layout scheduled.

• dom/Document.cpp:

(WebCore::Document::isLayoutPending const):
(WebCore::Document::isLayoutTimerActive const): Deleted.

• dom/Document.h:
• html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)
• dom/Document.h (modified) (1 diff)
• html/parser/HTMLParserScheduler.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-05  Alan Bujtas  <zalan@apple.com>
+
+        Document::isLayoutTimerActive should read isLayoutPending
+        https://bugs.webkit.org/show_bug.cgi?id=228835
+
+        Reviewed by Antti Koivisto.
+
+        Callers of this function curious about whether there's a layout scheduled.
+
+        * dom/Document.cpp:
+        (WebCore::Document::isLayoutPending const):
+        (WebCore::Document::isLayoutTimerActive const): Deleted.
+        * dom/Document.h:
+        * html/parser/HTMLParserScheduler.cpp:
+        (WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
+
 2021-08-05  Michael Catanzaro  <mcatanzaro@gnome.org>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -3247 +3247 @@
 }
     
-bool Document::isLayoutTimerActive() const
+bool Document::isLayoutPending() const
 {
     return view() && view()->layoutContext().isLayoutPending();

trunk/Source/WebCore/dom/Document.h

@@ -736 +736 @@
 
     bool shouldScheduleLayout() const;
-    bool isLayoutTimerActive() const;
+    bool isLayoutPending() const;
 #if !LOG_DISABLED
     Seconds timeSinceDocumentCreation() const { return MonotonicTime::now() - m_documentCreationTime; };

trunk/Source/WebCore/html/parser/HTMLParserScheduler.cpp

@@ -92 +92 @@
     // FIXME: The timer class should handle timer priorities instead of this code.
     // If a layout is scheduled, wait again to let the layout timer run first.
-    if (m_parser.document()->isLayoutTimerActive()) {
+    if (m_parser.document()->isLayoutPending()) {
         m_continueNextChunkTimer.startOneShot(0_s);
         return;