Changeset 280705 in webkit

Timestamp:

Aug 5, 2021, 3:47:59 PM (5 years ago)

Author:

Andres Gonzalez

Message:

VoiceOver is not announcing the state as selected/unselected when an item is selected in a grid.
​https://bugs.webkit.org/show_bug.cgi?id=228840
<rdar://78225826>

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/selected-state-changed-notifications.html.

On iOS, a table/grid cell element is not exposed to AX clients. Instead
the content of the cell is. This patch ensures that if the cell element
is selected, the AX objects that represent the content inside the cell
will inherit the selected state from the cell.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):

LayoutTests:

• accessibility/selected-state-changed-notifications.html:
• platform/ios/TestExpectations:
• platform/ios/accessibility/selected-state-changed-notifications-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/selected-state-changed-notifications.html (modified) (4 diffs)
• LayoutTests/platform/ios/TestExpectations (modified) (1 diff)
• LayoutTests/platform/ios/accessibility/selected-state-changed-notifications-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-08-05  Andres Gonzalez  <andresg_22@apple.com>
+
+        VoiceOver is not announcing the state as selected/unselected when an item is selected in a grid.
+        https://bugs.webkit.org/show_bug.cgi?id=228840
+        <rdar://78225826>
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/selected-state-changed-notifications.html:
+        * platform/ios/TestExpectations:
+        * platform/ios/accessibility/selected-state-changed-notifications-expected.txt: Added.
+
 2021-08-05  Tim Nguyen  <ntim@apple.com>
 

trunk/LayoutTests/accessibility/selected-state-changed-notifications.html

@@ -32 +32 @@
     if (window.accessibilityController) {
         window.jsTestIsAsync = true;
+        var platform = accessibilityController.platformName;
 
         var notificationCount = 0;
@@ -43 +44 @@
         var axSelectable = accessibilityController.accessibleElementById("selectable");
         shouldBeFalse("axSelectable.isSelected");
+        // On iOS, the cell element is not exposed to clients, but instead its content.
+        // So make sure that the selected state of the contained static text matches the state of the cell.
+        if (platform == "ios")
+            shouldBeFalse("axSelectable.children[0].isSelected");
 
         axSelectable.press();
@@ -50 +55 @@
             });
             shouldBeTrue("axSelectable.isSelected");
+            if (platform == "ios")
+                shouldBeTrue("axSelectable.children[0].isSelected");
 
             axSelectable.press();
@@ -56 +63 @@
             });
             shouldBeFalse("axSelectable.isSelected");
+            if (platform == "ios")
+                shouldBeFalse("axSelectable.children[0].isSelected");
 
             finishJSTest();

trunk/LayoutTests/platform/ios/TestExpectations

@@ -2103 +2103 @@
 webkit.org/b/150366 accessibility/aria-table-attributes.html [ Pass ]
 
+accessibility/selected-state-changed-notifications.html [ Pass ]
+
 # Enable "attachment element" test for iOS
 accessibility/attachment-element.html [ Pass ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-05  Andres Gonzalez  <andresg_22@apple.com>
+
+        VoiceOver is not announcing the state as selected/unselected when an item is selected in a grid.
+        https://bugs.webkit.org/show_bug.cgi?id=228840
+        <rdar://78225826>
+
+        Reviewed by Chris Fleizach.
+
+        Test: accessibility/selected-state-changed-notifications.html.
+
+        On iOS, a table/grid cell element is not exposed to AX clients. Instead
+        the content of the cell is. This patch ensures that if the cell element
+        is selected, the AX objects that represent the content inside the cell
+        will inherit the selected state from the cell.
+
+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+        (-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
+
 2021-08-05  Tim Nguyen  <ntim@apple.com>
 

trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

@@ -697 +697 @@
         case AccessibilityRole::Heading:
             traits |= [self _axHeaderTrait];
+            break;
+        case AccessibilityRole::Cell:
+        case AccessibilityRole::GridCell:
+            if (parent->isSelected())
+                traits |= [self _axSelectedTrait];
             break;
         default: