⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 280706 in webkit


Ignore:
Timestamp:
Aug 5, 2021, 4:47:09 PM (5 years ago)
Author:
Kate Cheney
Message:

LoadWebArchive.FailNavigation1 test is a false positive
​https://bugs.webkit.org/show_bug.cgi?id=228848
<rdar://problem/81587448>

Reviewed by Brent Fulgham.

Source/WebKit:

Drive by logging fix.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):

Tools:

Update LoadWebArchive.FailNavigation1 to test the case of a webarchive
being loaded with a host for better test coverage.

  • TestWebKitAPI/Tests/mac/load-web-archive-1.html:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r280702 r280706  
     12021-08-05  Kate Cheney  <katherine_cheney@apple.com>
     2
     3        LoadWebArchive.FailNavigation1 test is a false positive
     4        https://bugs.webkit.org/show_bug.cgi?id=228848
     5        <rdar://problem/81587448>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        Drive by logging fix.
     10
     11        * UIProcess/WebProcessProxy.cpp:
     12        (WebKit::WebProcessProxy::fetchWebsiteData):
     13        (WebKit::WebProcessProxy::deleteWebsiteData):
     14
    1152021-08-05  Eric Carlson  <eric.carlson@apple.com>
    216

  • trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp

    r280451 r280706  
    12461246#endif
    12471247        completionHandler(WTFMove(reply));
    1248         WEBPROCESSPROXY_RELEASE_LOG(ProcessSuspension, "fetchWebsiteData: Teleasing a background assertion because the Web process is done fetching Website data");
     1248        WEBPROCESSPROXY_RELEASE_LOG(ProcessSuspension, "fetchWebsiteData: Releasing a background assertion because the Web process is done fetching Website data");
    12491249    });
    12501250}
    … …  
    12621262#endif
    12631263        completionHandler();
    1264         WEBPROCESSPROXY_RELEASE_LOG(ProcessSuspension, "deleteWebsiteData: Teleasing a background assertion because the Web process is done deleting Website data");
     1264        WEBPROCESSPROXY_RELEASE_LOG(ProcessSuspension, "deleteWebsiteData: Releasing a background assertion because the Web process is done deleting Website data");
    12651265    });
    12661266}

  • trunk/Tools/ChangeLog

    r280682 r280706  
     12021-08-05  Kate Cheney  <katherine_cheney@apple.com>
     2
     3        LoadWebArchive.FailNavigation1 test is a false positive
     4        https://bugs.webkit.org/show_bug.cgi?id=228848
     5        <rdar://problem/81587448>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        Update LoadWebArchive.FailNavigation1 to test the case of a webarchive
     10        being loaded with a host for better test coverage.
     11
     12        * TestWebKitAPI/Tests/mac/load-web-archive-1.html:
     13
    1142021-08-05  Zan Dobersek  <zdobersek@igalia.com>
    215

  • trunk/Tools/TestWebKitAPI/Tests/mac/load-web-archive-1.html

    r241480 r280706  
    22<html>
    33<script>
    4     document.location.href = 'helloworld.webarchive';
     4    var url = new URL(location.href);
     5    var path = url.pathname.replace('load-web-archive-1.html', 'helloworld.webarchive');
     6    url.pathname = path;
     7    url.host = 'test';
     8
     9    document.location.href = url.href;
    510</script>
    611</html>
Note: See TracChangeset for help on using the changeset viewer.