Changeset 280713 in webkit

Timestamp:

Aug 5, 2021, 6:01:32 PM (5 years ago)

Author:

Ryan Haddad

Message:

REGRESSION (r279855): TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages is failing
​https://bugs.webkit.org/show_bug.cgi?id=228309

Unreviewed test gardening.

This test has been skipped on Apple Silicon because of timeouts, and
now it is a flaky failure on Intel machines. Disable it outright for
the time being.

• TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:

(TEST_F):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ -11 +11 @@
 
         * TestWebKitAPI/Tests/mac/load-web-archive-1.html:
+
+2021-08-05  Ryan Haddad  <ryanhaddad@apple.com>
+
+        REGRESSION (r279855): TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages is failing
+        https://bugs.webkit.org/show_bug.cgi?id=228309
+
+        Unreviewed test gardening.
+
+        This test has been skipped on Apple Silicon because of timeouts, and
+        now it is a flaky failure on Intel machines. Disable it outright for
+        the time be ing.
+
+        * TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:
+        (TEST_F):
 
 2021-08-05  Zan Dobersek  <zdobersek@igalia.com>

trunk/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm

@@ -59 +59 @@
 // On older macOSes, CFPREFS_DIRECT_MODE is disabled and the WebProcess does not see the updated AppleLanguages
 // after the AppleLanguagePreferencesChangedNotification notification.
-// FIXME: This test is currently disabled on Apple Silicon because it times out there (https://bugs.webkit.org/show_bug.cgi?id=222619).
-#if PLATFORM(MAC) && ENABLE(CFPREFS_DIRECT_MODE) && CPU(X86_64)
+#if PLATFORM(MAC) && ENABLE(CFPREFS_DIRECT_MODE)
 class AppleLanguagesTest : public testing::Test {
 public:
@@ -110 +109 @@
 }
 
-TEST_F(AppleLanguagesTest, UpdateAppleLanguages)
+// FIXME: This test times out on Apple Silicon (webkit.org/b/222619) and is a flaky failure on Intel (webkit.org/b/228309)
+TEST_F(AppleLanguagesTest, DISABLED_UpdateAppleLanguages)
 {
     preferenceObserverSharedInstanceCalled = false;