Changeset 280722 in webkit

Timestamp:

Aug 6, 2021, 8:04:13 AM (5 years ago)

Author:

eric.carlson@apple.com

Message:

REGRESSION: ASSERTION FAILED: !DeprecatedGlobalSettings::shouldManageAudioSessionCategory()

AudioSession::sharedSession().category() == AudioSession::CategoryType::PlayAndRecord

​https://bugs.webkit.org/show_bug.cgi?id=228847
<rdar://problem/81587101>

Reviewed by Jer Noble.

No new tests, fixes a crashing test.

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::SourceProxy::audioUnitWillStart): Restore.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-08-06  Eric Carlson  <eric.carlson@apple.com>
+
+        REGRESSION: ASSERTION FAILED: !DeprecatedGlobalSettings::shouldManageAudioSessionCategory() || AudioSession::sharedSession().category() == AudioSession::CategoryType::PlayAndRecord
+        https://bugs.webkit.org/show_bug.cgi?id=228847
+        <rdar://problem/81587101>
+
+        Reviewed by Jer Noble.
+
+        No new tests, fixes a crashing test.
+
+        * UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
+        (WebKit::UserMediaCaptureManagerProxy::SourceProxy::audioUnitWillStart): Restore.
+
 2021-08-05  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

@@ -101 +101 @@
     int64_t numberOfFrames() { return m_numberOfFrames; }
 
+    void audioUnitWillStart() final
+    {
+        AudioSession::sharedSession().setCategory(AudioSession::CategoryType::PlayAndRecord, RouteSharingPolicy::Default);
+    }
+
     void start()
     {