Changeset 280727 in webkit

Timestamp:

Aug 6, 2021, 9:52:46 AM (5 years ago)

Author:

Andres Gonzalez

Message:

Crash at WebKit::WebPage::requestTextRecognition caused by accessibility invocation.
​https://bugs.webkit.org/show_bug.cgi?id=228864
rdar://80679512

Reviewed by Chris Fleizach.

• accessibility/AXImage.cpp:

(WebCore::AXImage::imageOverlayElements):
It was calling requestTextRecognition with *element(), but element() can
return nullptr, which would lead to the crash.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AXImage.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-06  Andres Gonzalez  <andresg_22@apple.com>
+
+        Crash at WebKit::WebPage::requestTextRecognition caused by accessibility invocation.
+        https://bugs.webkit.org/show_bug.cgi?id=228864
+        rdar://80679512
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/AXImage.cpp:
+        (WebCore::AXImage::imageOverlayElements):
+        It was calling requestTextRecognition with *element(), but element() can
+        return nullptr, which would lead to the crash.
+
 2021-08-06  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/accessibility/AXImage.cpp

@@ -68 +68 @@
         return std::nullopt;
 
-    page->chrome().client().requestTextRecognition(*element(), [] (RefPtr<Element>&& imageOverlayHost) {
+    auto* element = this->element();
+    if (!element)
+        return std::nullopt;
+
+    page->chrome().client().requestTextRecognition(*element, [] (RefPtr<Element>&& imageOverlayHost) {
         if (!imageOverlayHost)
             return;