Changeset 280884 in webkit

Timestamp:

Aug 10, 2021, 11:10:27 PM (5 years ago)

Author:

Peng Liu

Message:

REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing
​https://bugs.webkit.org/show_bug.cgi?id=228926

Reviewed by Jer Noble.

Revert a part of r280726 while investigating the test failures.

• WebView/WebPreferencesDefaultValues.mm:

(WebKit::isFeatureFlagEnabled):

Location:

trunk/Source/WebKitLegacy/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebPreferencesDefaultValues.mm (modified) (1 diff)

trunk/Source/WebKitLegacy/mac/ChangeLog

@@ +1 @@
+2021-08-10  Peng Liu  <peng.liu6@apple.com>
+
+        REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing
+        https://bugs.webkit.org/show_bug.cgi?id=228926
+
+        Reviewed by Jer Noble.
+
+        Revert a part of r280726 while investigating the test failures.
+
+        * WebView/WebPreferencesDefaultValues.mm:
+        (WebKit::isFeatureFlagEnabled):
+
 2021-08-10  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm

@@ -50 +50 @@
 #if HAVE(SYSTEM_FEATURE_FLAGS)
 
-#if PLATFORM(MAC)
-    static bool isSystemWebKit = [] {
-        NSBundle *bundle = [NSBundle bundleForClass:NSClassFromString(@"WebView")];
-        return [bundle.bundlePath hasPrefix:@"/System/"];
-    }();
-
-    if (isSystemWebKit)
-        return _os_feature_enabled_impl("WebKit", (const char*)featureName.characters8());
-
-    return defaultValue;
-#else
+    // FIXME: On MacOS, we need to deal with the cases when system feature flags are not available.
+    // But we need to fix <http://webkit.org/b/228926> first.
+#if PLATFORM(COCOA)
     UNUSED_PARAM(defaultValue);
     return _os_feature_enabled_impl("WebKit", (const char*)featureName.characters8());