Changeset 280887 in webkit

Timestamp:

Aug 11, 2021, 12:43:42 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[SVG] Attribute change triggers redundant (and out of order) setNeedsLayout call
​https://bugs.webkit.org/show_bug.cgi?id=228125

Patch by Rob Buis <​rbuis@igalia.com> on 2021-08-11
Reviewed by Darin Adler.

As explained in the bug the setNeedsLayout call is redundant, however
keep using it for embedded SVG's to update width/height of the embedder.

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::svgAttributeChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/SVGSVGElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-11  Rob Buis  <rbuis@igalia.com>
+
+        [SVG] Attribute change triggers redundant (and out of order) setNeedsLayout call
+        https://bugs.webkit.org/show_bug.cgi?id=228125
+
+        Reviewed by Darin Adler.
+
+        As explained in the bug the setNeedsLayout call is redundant, however
+        keep using it for embedded SVG's to update width/height of the embedder.
+
+        * svg/SVGSVGElement.cpp:
+        (WebCore::SVGSVGElement::svgAttributeChanged):
+
 2021-08-10  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/svg/SVGSVGElement.cpp

@@ -210 +210 @@
         invalidateSVGPresentationalHintStyle();
 
-        if (auto renderer = this->renderer())
-            RenderSVGResource::markForLayoutAndParentResourceInvalidation(*renderer);
+        if (auto renderer = this->renderer()) {
+            if (is<RenderSVGRoot>(renderer) && downcast<RenderSVGRoot>(*renderer).isEmbeddedThroughFrameContainingSVGDocument())
+                RenderSVGResource::markForLayoutAndParentResourceInvalidation(*renderer);
+        }
         return;
     }
-    
+
     if (SVGFitToViewBox::isKnownAttribute(attrName)) {
         if (auto* renderer = this->renderer()) {