Changeset 280964 in webkit

Timestamp:

Aug 12, 2021, 6:51:16 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

[ATK] Critical warnings on children-changed::add signal emission
​https://bugs.webkit.org/show_bug.cgi?id=229030

Reviewed by Michael Catanzaro.

Implement AtkObjectClass::ref_state_set.

• WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp:

(webkitWebPageAccessibilityObjectRefStateSet): Return our child state set.
(webkit_web_page_accessibility_object_class_init): Add an implementation for AtkObjectClass::ref_state_set.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [ATK] Critical warnings on children-changed::add signal emission
+        https://bugs.webkit.org/show_bug.cgi?id=229030
+
+        Reviewed by Michael Catanzaro.
+
+        Implement AtkObjectClass::ref_state_set.
+
+        * WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp:
+        (webkitWebPageAccessibilityObjectRefStateSet): Return our child state set.
+        (webkit_web_page_accessibility_object_class_init): Add an implementation for AtkObjectClass::ref_state_set.
+
 2021-08-11  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp

@@ -140 +140 @@
 }
 
+static AtkStateSet* webkitWebPageAccessibilityObjectRefStateSet(AtkObject* atkObject)
+{
+    if (auto* rootObjectWrapper = accessibilityRootObjectWrapper(atkObject))
+        return atk_object_ref_state_set(rootObjectWrapper);
+
+    return atk_state_set_new();
+}
+
 static void webkit_web_page_accessibility_object_class_init(WebKitWebPageAccessibilityObjectClass* klass)
 {
@@ -150 +158 @@
     atkObjectClass->get_n_children = webkitWebPageAccessibilityObjectGetNChildren;
     atkObjectClass->ref_child = webkitWebPageAccessibilityObjectRefChild;
+    atkObjectClass->ref_state_set = webkitWebPageAccessibilityObjectRefStateSet;
 }