Changeset 280986 in webkit

Timestamp:

Aug 12, 2021, 2:13:45 PM (5 years ago)

Author:

Wenson Hsieh

Message:

[ iOS Debug] 3 editing/pasteboard/smart-paste-paragraph tests are flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=228285
rdar://81118724

Reviewed by Tim Horton and Aditya Keerthi.

Source/WebKit:

Add SPI declarations. See Tools/ChangeLog for more details.

• Platform/spi/ios/TextInputSPI.h:
• Platform/spi/ios/UIKitSPI.h:

Tools:

These three editing tests occasionally fail when synthesizing a double-tap gesture in order to select a word in
editable content. This happens because unless UIKit has observed at least one keypress event (e.g. from a
previous editing test), it presents the software keyboard underneath -[UIKeyboardImpl showKeyboardIfNeeded]
when setting the selection via UITextSelectionInteraction. This causes the input view frame to expand from the
collapsed (UCB) height of 44pt to the full software keyboard height, which in turn causes the second touch in
the synthesized double tap gesture to _sometimes_ hit-test to the wrong location, resulting in these test
failures.

To mitigate this, ensure that we have consistent behavior in layout tests when changing the text selection in
editable content by directly setting a TextInput default to make the keyboard behave as if it has previously
seen a keypress via the hardware keyboard.

• WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

LayoutTests:

Remove the flaky test failure expectations.

• platform/ios-wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/ios-wk2/TestExpectations (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Platform/spi/ios/TextInputSPI.h (modified) (1 diff)
• Source/WebKit/Platform/spi/ios/UIKitSPI.h (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/ios/TestControllerIOS.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [ iOS Debug] 3 editing/pasteboard/smart-paste-paragraph tests are flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=228285
+        rdar://81118724
+
+        Reviewed by Tim Horton and Aditya Keerthi.
+
+        Remove the flaky test failure expectations.
+
+        * platform/ios-wk2/TestExpectations:
+
 2021-08-12  Ayumi Kojima  <ayumi_kojima@apple.com>
 

trunk/LayoutTests/platform/ios-wk2/TestExpectations

@@ -1320 +1320 @@
 # <rdar://problem/56512107> [ iOS ] Three editing/pasteboard/smart-paste-paragraph tests have been flaky since they landed in r243124 (203264)
 webkit.org/b/203264 [ Release ] editing/pasteboard/smart-paste-paragraph-001.html [ Pass Failure ]
-webkit.org/b/228285 editing/pasteboard/smart-paste-paragraph-002.html [ Pass Failure ]
-webkit.org/b/228285 editing/pasteboard/smart-paste-paragraph-003.html [ Pass Failure ]
-webkit.org/b/228285 editing/pasteboard/smart-paste-paragraph-004.html [ Pass Failure ]
 
 # Timeout running prompt() because mock implementation is absent.

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [ iOS Debug] 3 editing/pasteboard/smart-paste-paragraph tests are flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=228285
+        rdar://81118724
+
+        Reviewed by Tim Horton and Aditya Keerthi.
+
+        Add SPI declarations. See Tools/ChangeLog for more details.
+
+        * Platform/spi/ios/TextInputSPI.h:
+        * Platform/spi/ios/UIKitSPI.h:
+
 2021-08-12  Said Abou-Hallawa  <said@apple.com>
 

trunk/Source/WebKit/Platform/spi/ios/TextInputSPI.h

@@ -28 +28 @@
 #if USE(APPLE_INTERNAL_SDK)
 
+#import <TextInput/TIPreferencesController.h>
 #import <TextInput/TI_NSStringExtras.h>
 
 #else
+
+@protocol TIPreferencesControllerActions <NSObject>
+- (BOOL)oneTimeActionCompleted:(NSString *)actionKey;
+- (void)didTriggerOneTimeAction:(NSString *)actionKey;
+@end
 
 @interface NSString (TextInputDetails)

trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h

@@ -1110 +1110 @@
 #endif
 
+@protocol TIPreferencesControllerActions;
+
 @interface UIKeyboardPreferencesController : NSObject
 + (UIKeyboardPreferencesController *)sharedPreferencesController;
@@ -1115 +1117 @@
 - (BOOL)boolForPreferenceKey:(NSString *)key;
 - (id)valueForPreferenceKey:(NSString *)key;
+@property (nonatomic, readonly) UIKeyboardPreferencesController<TIPreferencesControllerActions> *preferencesActions;
 @end
 

trunk/Tools/ChangeLog

@@ +1 @@
+2021-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [ iOS Debug] 3 editing/pasteboard/smart-paste-paragraph tests are flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=228285
+        rdar://81118724
+
+        Reviewed by Tim Horton and Aditya Keerthi.
+
+        These three editing tests occasionally fail when synthesizing a double-tap gesture in order to select a word in
+        editable content. This happens because unless UIKit has observed at least one keypress event (e.g. from a
+        previous editing test), it presents the software keyboard underneath `-[UIKeyboardImpl showKeyboardIfNeeded]`
+        when setting the selection via UITextSelectionInteraction. This causes the input view frame to expand from the
+        collapsed (UCB) height of 44pt to the full software keyboard height, which in turn causes the second touch in
+        the synthesized double tap gesture to _sometimes_ hit-test to the wrong location, resulting in these test
+        failures.
+
+        To mitigate this, ensure that we have consistent behavior in layout tests when changing the text selection in
+        editable content by directly setting a TextInput default to make the keyboard behave as if it has previously
+        seen a keypress via the hardware keyboard.
+
+        * WebKitTestRunner/ios/TestControllerIOS.mm:
+        (WTR::TestController::platformResetStateToConsistentValues):
+
 2021-08-12  Patrick Angle  <pangle@apple.com>
 

trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm

@@ -33 +33 @@
 #import "TestInvocation.h"
 #import "TestRunnerWKWebView.h"
+#import "TextInputSPI.h"
 #import "UIKitSPI.h"
 #import <Foundation/Foundation.h>
@@ -165 +166 @@
     }
 
+    // Ensures that changing selection does not cause the software keyboard to appear,
+    // even when the hardware keyboard is attached.
+    auto hardwareKeyboardLastSeenPreferenceKey = @"HardwareKeyboardLastSeen";
+    auto preferencesActions = keyboardPreferences.preferencesActions;
+    if (![preferencesActions oneTimeActionCompleted:hardwareKeyboardLastSeenPreferenceKey])
+        [preferencesActions didTriggerOneTimeAction:hardwareKeyboardLastSeenPreferenceKey];
+
     // Disables the dictation keyboard shortcut for testing.
     auto dictationKeyboardShortcutPreferenceKey = @"HWKeyboardDictationShortcut";