Changeset 280992 in webkit

Timestamp:

Aug 12, 2021, 4:26:58 PM (5 years ago)

Author:

Chris Dumez

Message:

REGRESSION (iPadOS 14): [ iPadOS wk2 ] TestWebKitAPI.ServiceWorkers.SuspendNetworkProcess is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=217714
<rdar://problem/70296664>

Reviewed by Geoffrey Garen.

Give the database some time to get written out to disk before we try and suspend the network process, to try
and address the flakiness.

• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-08-12  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (iPadOS 14): [ iPadOS wk2 ] TestWebKitAPI.ServiceWorkers.SuspendNetworkProcess is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=217714
+        <rdar://problem/70296664>
+
+        Reviewed by Geoffrey Garen.
+
+        Give the database some time to get written out to disk before we try and suspend the network process, to try
+        and address the flakiness.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
 2021-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm

@@ -1946 +1946 @@
     NSURL *swDBPath = [directory URLByAppendingPathComponent:@"ServiceWorkerRegistrations-7.sqlite3"];
 
+    unsigned timeout = 0;
+    while (![[NSFileManager defaultManager] fileExistsAtPath:swDBPath.path] && ++timeout < 100)
+        TestWebKitAPI::Util::sleep(0.1);
+
     EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:swDBPath.path]);