Changeset 280999 in webkit

Timestamp:

Aug 12, 2021, 5:08:04 PM (5 years ago)

Author:

Chris Dumez

Message:

Regression(r273194) Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased
​https://bugs.webkit.org/show_bug.cgi?id=229056

Reviewed by Geoffrey Garen.

Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased. I got this wrong
in r273194.

• Misc/WebNSObjectExtras.mm:

(-[WebMainThreadInvoker forwardInvocation:]):

Location:

trunk/Source/WebKitLegacy/mac

Files:

• ChangeLog (modified) (1 diff)
• Misc/WebNSObjectExtras.mm (modified) (1 diff)

trunk/Source/WebKitLegacy/mac/ChangeLog

@@ +1 @@
+2021-08-12  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r273194) Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased
+        https://bugs.webkit.org/show_bug.cgi?id=229056
+
+        Reviewed by Geoffrey Garen.
+
+        Exception being thrown in [WebMainThreadInvoker forwardInvocation] should be autoreleased. I got this wrong
+        in r273194.
+
+        * Misc/WebNSObjectExtras.mm:
+        (-[WebMainThreadInvoker forwardInvocation:]):
+
 2021-08-12  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKitLegacy/mac/Misc/WebNSObjectExtras.mm

@@ -64 +64 @@
     if (exception) {
         auto exceptionToThrow = std::exchange(exception, nil);
-        @throw exceptionToThrow.get();
+        @throw exceptionToThrow.autorelease();
     } else if (returnTypeIsObject(invocation)) {
         // _webkit_invokeAndHandleException retained the return value on the main thread.