⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 281010 in webkit


Ignore:
Timestamp:
Aug 13, 2021, 1:40:04 AM (5 years ago)
Author:
Martin Robinson
Message:

Get lint-test-expectations passing
​https://bugs.webkit.org/show_bug.cgi?id=228999

Reviewed by Ryan Haddad.

Tools:

  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:

(LayoutTestFinder._is_test_file): Added a list of patterns for tests to skip
and ensured that 'boot.xml' and 'root.xml' (spurious files created during
the run of the WebKit1 bot) are on the list.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:

(LayoutTestFinderTests.test_is_test_file): Added a test for the changes.

LayoutTests:

  • TestExpectations: Remove expectation for non-existent test.
  • platform/ios-simulator/TestExpectations: Ditto.
  • platform/ios-wk2/TestExpectations: Ditto.
  • platform/ios/TestExpectations: Dito.
  • platform/mac-wk1/TestExpectations: Ditto. Also, the expectations for the non-test

'boot.xml' and 'root.xml' have been moved to workarounds in webkitpy.

  • platform/mac/TestExpectations: Remove references to non-existent tests. Also combined

one expectation that was not linting due to a problem like the one described in bug
120081.

  • platform/win/TestExpectations: Ditto.
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r281009 r281010  
     12021-08-13  Martin Robinson  <mrobinson@webkit.org>
     2
     3        Get lint-test-expectations passing
     4        https://bugs.webkit.org/show_bug.cgi?id=228999
     5
     6        Reviewed by Ryan Haddad.
     7
     8        * TestExpectations: Remove expectation for non-existent test.
     9        * platform/ios-simulator/TestExpectations: Ditto.
     10        * platform/ios-wk2/TestExpectations: Ditto.
     11        * platform/ios/TestExpectations: Dito.
     12        * platform/mac-wk1/TestExpectations: Ditto. Also, the expectations for the non-test
     13        'boot.xml' and 'root.xml' have been moved to workarounds in webkitpy.
     14        * platform/mac/TestExpectations: Remove references to non-existent tests. Also combined
     15        one expectation that was not linting due to a problem like the one described in bug
     16        120081.
     17        * platform/win/TestExpectations: Ditto.
     18
    1192021-08-12  Alex Christensen  <achristensen@webkit.org>
    220

  • trunk/LayoutTests/TestExpectations

    r280980 r281010  
    11381138imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-TAO.sub.html [ Pass Failure ]
    11391139imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-partial-TAO.sub.html [ Pass Failure ]
    1140 imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html [ Pass Failure ]
    11411140imported/w3c/web-platform-tests/navigation-timing/secure_connection_start_non_zero.https.html [ Pass Failure ]
    11421141imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html [ Pass Failure ]

  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r280054 r281010  
    115115webkit.org/b/222685 webgl/1.0.3/conformance/textures/texture-mips.html [ Pass Failure ]
    116116
    117 # WebGPU is not enabled on iOS Simulator.
    118 webgpu [ Skip ]
    119 
    120117# webkit.org/b/223724 These two tests are flakey timeouts on iOS Debug:
    121118http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html [ Pass Timeout ]

  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r280986 r281010  
    12171217webkit.org/b/171331 http/tests/preload/single_download_preload.html [ Pass Failure ]
    12181218
    1219 webkit.org/b/170699 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html [ Pass Failure ]
    1220 
    12211219webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]
    12221220
    … …  
    12901288
    12911289webkit.org/b/176030 http/tests/websocket/tests/hybi/send-object-tostring-check.html [ Pass Failure ]
    1292 
    1293 webkit.org/b/199013 [ Debug ] imported/w3c/web-platform-tests/websockets/Create-Secure-verify-url-set-non-default-port.any.html [ Pass Failure ]
    12941290
    12951291webkit.org/b/196495 fast/viewport/ios/viewport-shrink-to-fit-on-new-navigation.html [ Failure ]

  • trunk/LayoutTests/platform/ios/TestExpectations

    r280980 r281010  
    26472647webkit.org/b/155092 js/arraybuffer-wrappers.html [ Pass Timeout ]
    26482648
    2649 webkit.org/b/172052 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/type-long-setinterval.html [ Pass Failure ]
    2650 
    26512649webkit.org/b/183441 mathml/presentation/multiscripts-equivalence.html [ ImageOnlyFailure ]
    26522650

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r280994 r281010  
    130130webkit.org/b/156069 http/tests/security/anchor-download-octet-stream-no-extension.html [ Skip ]
    131131webkit.org/b/156069 http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html [ Skip ]
    132 http/tests/security/frame-src-and-blob-download.https.html [ Skip ]
    133132
    134133# Not supported on WK1
    … …  
    11831182webkit.org/b/221009 fast/harness/render-tree-as-text-options.html [ Pass Failure ]
    11841183
    1185 webkit.org/b/208477 [ Catalina ] accessibility/mac/test.mp3/boot.xml [ Skip ]
    1186 webkit.org/b/208479 [ Catalina ] accessibility/mac/test.mp3/root.xml [ Skip ]
    1187 
    11881184webkit.org/b/221095 [ BigSur+ ] media/mediacapabilities/vp9.html [ Skip ]
    11891185

  • trunk/LayoutTests/platform/mac/TestExpectations

    r280948 r281010  
    21132113[ arm64 ] webrtc/concurrentVideoPlayback2.html [ Pass Timeout ]
    21142114[ arm64 ] webrtc/concurrentVideoPlayback.html [ Pass Timeout ]
    2115 [ arm64 ] webrtc/direction-change.html [ Pass Timeout ]
    21162115[ arm64 ] webrtc/multi-video.html [ Pass Timeout ]
    21172116[ arm64 ] webrtc/h265.html [ Pass Timeout ]
    … …  
    22172216webkit.org/b/225425 [ Debug ] webgl/1.0.3/conformance/glsl/misc/expression-list-in-declarator-initializer.html [ Pass Timeout ]
    22182217
    2219 webkit.org/b/225523 webrtc/direction-change.html [ Pass Failure ]
     2218# This test is a flaky timeout on Apple Silicon and a flaky failure on other platforms.
     2219# See https://webkit.org/b/120081 for why this is one expectation.
     2220webkit.org/b/225523 webrtc/direction-change.html [ Pass Timeout Failure ]
    22202221
    22212222webkit.org/b/22525 webrtc/video-replace-muted-track.html [ Pass Failure ]

  • trunk/LayoutTests/platform/win/TestExpectations

    r280953 r281010  
    109109webkit.org/b/173281 editing/selection/selection-across-shadow-boundaries-readonly-3.html [ Skip ]
    110110webkit.org/b/173281 editing/selection/selection-across-shadow-boundaries-user-select-all-1.html [ Skip ]
    111 webkit.org/b/193748 http/tests/adClickAttribution [ Skip ]
    112111http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html [ Skip ]
    113112
    … …  
    226225webkit.org/b/29287 http/tests/local/blob/send-hybrid-blob.html [ Skip ]
    227226webkit.org/b/29287 http/tests/local/formdata/ [ Skip ]
    228 http/tests/security/frame-src-and-blob-download.https.html [ Skip ]
    229227
    230228# Software keyboard is not supported.
    … …  
    421419webkit.org/b/42435 http/tests/misc/webtiming-cross-origin-redirect.py [ Skip ]
    422420webkit.org/b/42435 http/tests/misc/webtiming-no-origin.html [ Skip ]
    423 webkit.org/b/42435 http/tests/misc/webtiming-one-redirect.php [ Skip ]
    424421webkit.org/b/42435 http/tests/misc/webtiming-resolution.html [ Skip ]
    425 webkit.org/b/42435 http/tests/misc/webtiming-slow-load.php [ Skip ]
    426 webkit.org/b/42435 http/tests/misc/webtiming-ssl.php [ Skip ]
    427 webkit.org/b/42435 http/tests/misc/webtiming-two-redirects.php [ Skip ]
    428422
    429423# TODO Application Cache Quotas
    … …  
    21312125webkit.org/b/140703 [ Release ] http/tests/loading/redirect-methods.html [ Failure ]
    21322126webkit.org/b/140703 [ Debug ] http/tests/loading/redirect-methods.html [ Skip ] # Debug assertion
    2133 webkit.org/b/140703 http/tests/misc/401-alternative-content.php [ Failure ]
    21342127webkit.org/b/140703 http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html [ Failure ]
    21352128webkit.org/b/140703 http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html [ Failure ]
    … …  
    22922285http/tests/misc/async-script-removed.html [ Failure ]
    22932286http/tests/misc/bad-charset-alias.html
    2294 http/tests/misc/refresh-headers.php [ Failure ] # Easy
    22952287http/tests/multipart/load-last-non-html-frame.py [ Failure ] # Extra whitespace
    22962288http/tests/navigation/no-referrer-reset.html [ Failure ] # Easy

  • trunk/Tools/ChangeLog

    r281006 r281010  
     12021-08-13  Martin Robinson  <mrobinson@webkit.org>
     2
     3        Get lint-test-expectations passing
     4        https://bugs.webkit.org/show_bug.cgi?id=228999
     5
     6        Reviewed by Ryan Haddad.
     7
     8        * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
     9        (LayoutTestFinder._is_test_file): Added a list of patterns for tests to skip
     10        and ensured that 'boot.xml' and 'root.xml' (spurious files created during
     11        the run of the WebKit1 bot) are on the list.
     12        * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
     13        (LayoutTestFinderTests.test_is_test_file): Added a test for the changes.
     14
    1152021-08-12  Lauro Moura  <lmoura@igalia.com>
    216

  • trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py

    r277490 r281010  
    4343_supported_test_extensions = set(['.html', '.shtml', '.xml', '.xhtml', '.pl', '.py', '.htm', '.php', '.svg', '.mht', '.xht'])
    4444
     45_skipped_filename_patterns = set([
     46    # Special case for WebSocket tooling.
     47    r'.*_wsh.py',
     48
     49    # The WebKit1 bot sometimes creates these files during the course of testing.
     50    # https://webkit.org/b/208477
     51    r'boot\.xml',
     52    r'root\.xml'
     53])
     54
    4555
    4656# If any changes are made here be sure to update the isUsedInReftest method in old-run-webkit-tests as well.
    … …  
    136146        if self._is_w3c_resource_file(filesystem, dirname, filename):
    137147            return False
    138         # Special case for websocket tooling
    139         if filename.endswith('_wsh.py'):
    140             return False
     148
     149        for pattern in _skipped_filename_patterns:
     150            if re.match(pattern, filename):
     151                return False
    141152        return True
    142153

  • trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py

    r273854 r281010  
    106106        self.assertFalse(finder._is_test_file(finder._filesystem, '', 'ref-foo.html'))
    107107        self.assertFalse(finder._is_test_file(finder._filesystem, '', 'notref-foo.xhr'))
     108        self.assertFalse(finder._is_test_file(finder._filesystem, '', 'foo_wsh.py'))
     109        self.assertFalse(finder._is_test_file(finder._filesystem, '', '_wsh.py'))
     110        self.assertFalse(finder._is_test_file(finder._filesystem, '', 'boot.xml'))
     111        self.assertFalse(finder._is_test_file(finder._filesystem, '', 'root.xml'))
     112        self.assertTrue(finder._is_test_file(finder._filesystem, '', 'foo-boot.xml'))
     113        self.assertTrue(finder._is_test_file(finder._filesystem, '', 'foo-root.xml'))
    108114
    109115    def test_is_w3c_resource_file(self):
Note: See TracChangeset for help on using the changeset viewer.