Changeset 281015 in webkit

Timestamp:

Aug 13, 2021, 7:40:23 AM (5 years ago)

Author:

Lauro Moura

Message:

[WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=229067

Reviewed by Carlos Garcia Campos.

• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebKitWebViewProcessCrashed): Make warnings non-fatal while waiting for the crash.

• TestWebKitAPI/glib/TestExpectations.json: Remove expectation

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp (modified) (1 diff)
• TestWebKitAPI/glib/TestExpectations.json (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-08-13  Lauro Moura  <lmoura@igalia.com>
+
+        [WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing
+        https://bugs.webkit.org/show_bug.cgi?id=229067
+
+        Reviewed by Carlos Garcia Campos.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
+        (testWebKitWebViewProcessCrashed): Make warnings non-fatal while waiting for the crash.
+        * TestWebKitAPI/glib/TestExpectations.json: Remove expectation
+
 2021-08-13  Martin Robinson  <mrobinson@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp

@@ -162 +162 @@
         -1, 0, 0));
     g_assert_null(result);
+    Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
     g_main_loop_run(test->m_mainLoop);
+    Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);
     test->m_expectedWebProcessCrash = false;
 }

trunk/Tools/TestWebKitAPI/glib/TestExpectations.json

@@ -75 +75 @@
     "TestWebExtensions": {
         "subtests": {
-            "/webkit/WebKitWebView/web-process-crashed": {
-                "expected": {"wpe": {"status": ["FAIL", "PASS"], "bug": ["webkit.org/b/229067"]}}
-            },
             "/webkit/WebKitWebView/install-missing-plugins-permission-request": {
                 "expected": {"gtk": {"status": ["TIMEOUT", "FAIL"], "bug": ["webkit.org/b/147822", "webkit.org/b/210635"]}}