Changeset 281030 in webkit

Timestamp:

Aug 13, 2021, 12:30:44 PM (5 years ago)

Author:

youenn@apple.com

Message:

Use profile auto level for WebRTC H264 encoder on Apple Silicon
​https://bugs.webkit.org/show_bug.cgi?id=229071
<rdar://80345048>

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

AS H264 encoder will fail if its profile is too low compared to the size of the video.
Use autolevel to prevent this.

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

LayoutTests:

• platform/mac/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• Source/ThirdParty/libwebrtc/ChangeLog (modified) (1 diff)
• Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-08-13  Youenn Fablet  <youenn@apple.com>
+
+        Use profile auto level for WebRTC H264 encoder on Apple Silicon
+        https://bugs.webkit.org/show_bug.cgi?id=229071
+        <rdar://80345048>
+
+        Reviewed by Eric Carlson.
+
+        * platform/mac/TestExpectations:
+
 2021-08-13  Alex Christensen  <achristensen@webkit.org>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -2122 +2122 @@
 [ arm64 ] webrtc/video-with-data-channel.html [ Pass Timeout ]
 [ arm64 ] webrtc/video-unmute.html [ Pass Timeout ]
-[ arm64 ] webrtc/h264-high.html [ Skip ]
 [ arm64 ] webrtc/vp9-profile2.html [ Skip ]
 [ arm64 ] webrtc/captureCanvas-webrtc-software-h264-high.html [ Pass Failure ]

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2021-08-13  Youenn Fablet  <youenn@apple.com>
+
+        Use profile auto level for WebRTC H264 encoder on Apple Silicon
+        https://bugs.webkit.org/show_bug.cgi?id=229071
+        <rdar://80345048>
+
+        Reviewed by Eric Carlson.
+
+        AS H264 encoder will fail if its profile is too low compared to the size of the video.
+        Use autolevel to prevent this.
+        * Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+
 2021-07-01  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm

@@ -261 +261 @@
     case webrtc::H264::kProfileConstrainedHigh:
     case webrtc::H264::kProfileHigh:
+#if !defined(WEBRTC_ARCH_ARM64)
       switch (profile_level_id.level) {
         case webrtc::H264::kLevel3:
@@ -290 +291 @@
           return kVTProfileLevel_H264_High_AutoLevel;
       }
+#else
+      return kVTProfileLevel_H264_High_AutoLevel;
+#endif
   }
 }