Changeset 281178 in webkit

Timestamp:

Aug 17, 2021, 7:27:03 PM (5 years ago)

Author:

sbarati@apple.com

Message:

Add an option for canonicalizePrePostIncrements
​https://bugs.webkit.org/show_bug.cgi?id=229211
<rdar://problem/82050126>

Reviewed by Mark Lam.

The current phase has bugs. Let's disable it for now until the bugs
are fixed. See discussion about the bugs I spotted in:
​https://bugs.webkit.org/show_bug.cgi?id=228538

• b3/B3Generate.cpp:

(JSC::B3::generateToAir):

• b3/testb3_3.cpp:

(addShrTests):

• runtime/OptionsList.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• b3/B3Generate.cpp (modified) (1 diff)
• b3/testb3_3.cpp (modified) (1 diff)
• runtime/OptionsList.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-08-17  Saam Barati  <sbarati@apple.com>
+
+        Add an option for canonicalizePrePostIncrements
+        https://bugs.webkit.org/show_bug.cgi?id=229211
+        <rdar://problem/82050126>
+
+        Reviewed by Mark Lam.
+
+        The current phase has bugs. Let's disable it for now until the bugs
+        are fixed. See discussion about the bugs I spotted in:
+        https://bugs.webkit.org/show_bug.cgi?id=228538
+
+        * b3/B3Generate.cpp:
+        (JSC::B3::generateToAir):
+        * b3/testb3_3.cpp:
+        (addShrTests):
+        * runtime/OptionsList.h:
+
 2021-08-16  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/b3/B3Generate.cpp

@@ -119 +119 @@
     legalizeMemoryOffsets(procedure);
     moveConstants(procedure);
-    if (procedure.optLevel() >= 2)
+    if (Options::useB3CanonicalizePrePostIncrements() && procedure.optLevel() >= 2)
         canonicalizePrePostIncrements(procedure);
     eliminateDeadCode(procedure);

trunk/Source/JavaScriptCore/b3/testb3_3.cpp

@@ -4098 +4098 @@
     RUN(testZShrArgImm32(0xffffffff, 63));
 
-    RUN(testLoadPreIndex32());
-    RUN(testLoadPreIndex64());
-    RUN(testLoadPostIndex32());
-    RUN(testLoadPostIndex64());
-
-    RUN(testStorePreIndex32());
-    RUN(testStorePreIndex64());
-    RUN(testStorePostIndex32());
-    RUN(testStorePostIndex64());
+    if (Options::useB3CanonicalizePrePostIncrements()) {
+        RUN(testLoadPreIndex32());
+        RUN(testLoadPreIndex64());
+        RUN(testLoadPostIndex32());
+        RUN(testLoadPostIndex64());
+
+        RUN(testStorePreIndex32());
+        RUN(testStorePreIndex64());
+        RUN(testStorePostIndex32());
+        RUN(testStorePostIndex64());
+    }
 }
 

trunk/Source/JavaScriptCore/runtime/OptionsList.h

@@ -438 +438 @@
     v(Unsigned, maxB3TailDupBlockSuccessors, 3, Normal, nullptr) \
     v(Bool, useB3HoistLoopInvariantValues, false, Normal, nullptr) \
+    v(Bool, useB3CanonicalizePrePostIncrements, false, Normal, nullptr) \
     \
     v(Bool, useDollarVM, false, Restricted, "installs the $vm debugging tool in global objects") \