Changeset 281181 in webkit

Timestamp:

Aug 17, 2021, 11:26:20 PM (5 years ago)

Author:

achristensen@apple.com

Message:

Mark test as flaky: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
​https://bugs.webkit.org/show_bug.cgi?id=229181

• TestExpectations:

r281147 changed this test from flaky to differently flaky.
It used to pass sometimes because the whole document would load before any script was executed, so there was no PerformanceNavigationTiming
object to update as the document loaded. r281147 fixed that, making it basically always pass when loaded over the real internet.
Now, sometimes it loads locally so fast that Performance::reduceTimeResolution makes some of the values 0, which is allowed by the spec but not
by the tests. In practice, pages don't load over the internet in less than 1ms, so this isn't much of an issue, just in our test bots.
I'll propose a fix for the web platform test, but for now I mark it as flaky.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-08-17  Alex Christensen  <achristensen@webkit.org>
+
+        Mark test as flaky: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
+        https://bugs.webkit.org/show_bug.cgi?id=229181
+
+        * TestExpectations:
+        r281147 changed this test from flaky to differently flaky.
+        It used to pass sometimes because the whole document would load before any script was executed, so there was no PerformanceNavigationTiming
+        object to update as the document loaded.  r281147 fixed that, making it basically always pass when loaded over the real internet.
+        Now, sometimes it loads locally so fast that Performance::reduceTimeResolution makes some of the values 0, which is allowed by the spec but not
+        by the tests.  In practice, pages don't load over the internet in less than 1ms, so this isn't much of an issue, just in our test bots.
+        I'll propose a fix for the web platform test, but for now I mark it as flaky.
+
 2021-08-17  Arcady Goldmints-Orlov  <agoldmints@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -1133 +1133 @@
 imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-partial-TAO.sub.html [ Pass Failure ]
 imported/w3c/web-platform-tests/navigation-timing/secure_connection_start_non_zero.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html [ Pass Failure ]
 imported/w3c/web-platform-tests/resource-timing/TAO-match.html [ Pass Failure ]
 imported/w3c/web-platform-tests/resource-timing/iframe-failed-commit.html [ Pass Failure ]