Changeset 281658 in webkit

Timestamp:

Aug 26, 2021, 2:59:19 PM (5 years ago)

Author:

Patrick Angle

Message:

[ EWS Catalina ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is flaky timing out / failing
​https://bugs.webkit.org/show_bug.cgi?id=229459

Reviewed by Devin Rousso.

Increase timings slightly to widen the window during which we receive messages while paused in the debugger and
also delay the echo server's response further.

• http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py:

(web_socket_transfer_data):

• http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py (modified) (1 diff)
• http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-08-26  Patrick Angle  <pangle@apple.com>
+
+        [ EWS Catalina ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is flaky timing out / failing
+        https://bugs.webkit.org/show_bug.cgi?id=229459
+
+        Reviewed by Devin Rousso.
+
+        Increase timings slightly to widen the window during which we receive messages while paused in the debugger and
+        also delay the echo server's response further.
+
+        * http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py:
+        (web_socket_transfer_data):
+        * http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html:
+        * platform/mac/TestExpectations:
+
 2021-08-26  Robert Jenner  <Jenner@apple.com>
 

trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py

@@ -10 +10 @@
     # Echo message back
     message = msgutil.receive_message(request)
-    sleep(0.1)
+    sleep(0.25)
     msgutil.send_message(request, message)

trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html

@@ -51 +51 @@
                         InspectorTest.evaluateInPage(`debugger`);
 
-                        // The WebSocket echos with a 100ms delay, so wait a bit longer than that before resuming to
+                        // The WebSocket echos with a 250ms delay, so wait a bit longer than that before resuming to
                         // ensure we receive the message while still paused.
                         setTimeout(() => {
                                 InspectorTest.log("Resuming script execution.")
                                 WI.debuggerManager.resume().catch(reject);
-                        }, 200);
+                        }, 500);
                     } else if (frameAddedCount === 2) {
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -656 +656 @@
 
 webkit.org/b/89153 http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]
-
-webkit.org/b/229459 [ Debug ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html [ Pass Failure Timeout ]
 
 # <rdar://problem/16696298>