Changeset 282008 in webkit

Timestamp:

Sep 3, 2021, 10:30:39 AM (5 years ago)

Author:

Ziran Sun

Message:

REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows
​https://bugs.webkit.org/show_bug.cgi?id=228325

Reviewed by Javier Fernandez.

Source/WebCore:

The is to fix regression caused by r280078. After updating overridingLogicalWidth,
there is no need to reset the logicalWidth.

No test needed. Test fast/images/exif-orientation-composited.html is enough to cover
the affected code.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):

LayoutTests:

• platform/win/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/win/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderGrid.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-09-03  Ziran Sun  <zsun@igalia.com>
+
+        REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows
+        https://bugs.webkit.org/show_bug.cgi?id=228325
+
+        Reviewed by Javier Fernandez.
+
+        * platform/win/TestExpectations:
+
 2021-09-03  Ayumi Kojima  <ayumi_kojima@apple.com>
 

trunk/LayoutTests/platform/win/TestExpectations

@@ -3787 +3787 @@
 webkit.org/b/177216 fast/images/animated-image-mp4.html [ Skip ]
 
-webkit.org/b/228325 fast/images/exif-orientation-composited.html [ Pass ImageOnlyFailure ]
-
 webkit.org/b/177234 http/wpt/resource-timing/rt-cors.html [ Skip ]
 webkit.org/b/177234 http/wpt/resource-timing/rt-cors.worker.html [ Skip ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-03  Ziran Sun  <zsun@igalia.com>
+
+        REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows
+        https://bugs.webkit.org/show_bug.cgi?id=228325
+
+        Reviewed by Javier Fernandez.
+
+        The is to fix regression caused by r280078. After updating overridingLogicalWidth,
+        there is no need to reset the logicalWidth.
+
+        No test needed. Test fast/images/exif-orientation-composited.html is enough to cover
+        the affected code.
+   
+        * rendering/RenderGrid.cpp:
+        (WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
+
 2021-09-03  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/rendering/RenderGrid.cpp

@@ -1178 +1178 @@
         LayoutUnit desiredLogicalWidth = constrainLogicalWidthInFragmentByMinMax(stretchedLogicalWidth, contentWidth(), *this, nullptr);
         child.setOverridingLogicalWidth(desiredLogicalWidth);
-        if (desiredLogicalWidth != child.logicalWidth()) {
-            child.setLogicalWidth(0_lu);
+        if (desiredLogicalWidth != child.logicalWidth())
             child.setNeedsLayout(MarkOnlyThis);
-        }
     } 
 }