Changeset 282177 in webkit

Timestamp:

Sep 8, 2021, 3:54:37 PM (5 years ago)

Author:

Fujii Hironori

Message:

REGRESSION(r282115): undefined reference to `IPC::messageArgumentDescriptions(IPC::MessageName)' in Debug build
​https://bugs.webkit.org/show_bug.cgi?id=230064

Unreviewed build fix.

Debug build of non-Cocoa ports were broken since r282115 started
to use IPC::messageArgumentDescriptions for debug logging.
However, MessageArgumentDescriptions.cpp has a long-standing
compilation problem for non-Cocoa ports.

Temporarily disabled the debug logging for non-Cocoa ports by
using ENABLE(IPC_TESTING_API) macro. I'll revert this change after
I will fix the fundamental problem of messages.py.

• Platform/IPC/HandleMessage.h:

(IPC::logMessageImpl):
(IPC::logReply):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/IPC/HandleMessage.h (modified) (3 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-09-08  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        REGRESSION(r282115): undefined reference to `IPC::messageArgumentDescriptions(IPC::MessageName)' in Debug build
+        https://bugs.webkit.org/show_bug.cgi?id=230064
+
+        Unreviewed build fix.
+
+        Debug build of non-Cocoa ports were broken since r282115 started
+        to use IPC::messageArgumentDescriptions for debug logging.
+        However, MessageArgumentDescriptions.cpp has a long-standing
+        compilation problem for non-Cocoa ports.
+
+        Temporarily disabled the debug logging for non-Cocoa ports by
+        using ENABLE(IPC_TESTING_API) macro. I'll revert this change after
+        I will fix the fundamental problem of messages.py.
+
+        * Platform/IPC/HandleMessage.h:
+        (IPC::logMessageImpl):
+        (IPC::logReply):
+
 2021-09-08  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebKit/Platform/IPC/HandleMessage.h

@@ -48 +48 @@
 constexpr unsigned loggingContainerSizeLimit = 200;
 
-#if !LOG_DISABLED
+#if !LOG_DISABLED && ENABLE(IPC_TESTING_API)
 enum class ForReply : bool { No, Yes };
 
@@ -74 +74 @@
 void logMessageImpl(const Connection& connection, MessageName messageName, const ArgsTuple& args, std::index_sequence<ArgsIndex...>)
 {
-#if !LOG_DISABLED
+#if !LOG_DISABLED && ENABLE(IPC_TESTING_API)
     auto stream = textStreamForLogging(connection, messageName, ForReply::No);
 
@@ -97 +97 @@
 void logReply(const Connection& connection, MessageName messageName, const T&... args)
 {
-#if !LOG_DISABLED
+#if !LOG_DISABLED && ENABLE(IPC_TESTING_API)
     if (!sizeof...(T))
         return;