Changeset 282193 in webkit

Timestamp:

Sep 8, 2021, 11:49:35 PM (5 years ago)

Author:

youenn@apple.com

Message:

Add video metrics logging to LocalSampleBufferDisplayLayer
​https://bugs.webkit.org/show_bug.cgi?id=229930

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

• platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:

(WebCore::LocalSampleBufferDisplayLayer::enqueueSampleBuffer):
Log every minute AVSBDL metrics, which can help to evaluate video freeze issues.

Source/WebCore/PAL:

• PAL/pal/spi/cocoa/AVFoundationSPI.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• PAL/ChangeLog (modified) (1 diff)
• PAL/pal/spi/cocoa/AVFoundationSPI.h (modified) (2 diffs)
• platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-08  Youenn Fablet  <youenn@apple.com>
+
+        Add video metrics logging to LocalSampleBufferDisplayLayer
+        https://bugs.webkit.org/show_bug.cgi?id=229930
+
+        Reviewed by Eric Carlson.
+
+        No change of behavior.
+
+        * platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
+        (WebCore::LocalSampleBufferDisplayLayer::enqueueSampleBuffer):
+        Log every minute AVSBDL metrics, which can help to evaluate video freeze issues.
+
 2021-09-08  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Source/WebCore/PAL/ChangeLog

@@ +1 @@
+2021-09-08  Youenn Fablet  <youenn@apple.com>
+
+        Add video metrics logging to LocalSampleBufferDisplayLayer
+        https://bugs.webkit.org/show_bug.cgi?id=229930
+
+        Reviewed by Eric Carlson.
+
+        * PAL/pal/spi/cocoa/AVFoundationSPI.h:
+
 2021-09-08  Per Arne  <pvollan@apple.com>
 

trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h

@@ -372 +372 @@
 @property (nonatomic, readonly) unsigned long numberOfCorruptedVideoFrames;
 @property (nonatomic, readonly) unsigned long numberOfDisplayCompositedVideoFrames;
+@property (nonatomic, readonly) unsigned long numberOfNonDisplayCompositedVideoFrames;
 @property (nonatomic, readonly) double totalFrameDelay;
 @end
@@ -377 +378 @@
 @interface AVVideoPerformanceMetrics (AVVideoPerformanceMetricsDisplayCompositedVideoFrames)
 @property (nonatomic, readonly) unsigned long numberOfDisplayCompositedVideoFrames;
+@property (nonatomic, readonly) unsigned long numberOfNonDisplayCompositedVideoFrames;
 @end
 #endif

trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm

@@ -42 +42 @@
 #import <wtf/cf/TypeCastsCF.h>
 
+#import <pal/spi/cocoa/AVFoundationSPI.h>
+
 #import <pal/cocoa/AVFoundationSoftLink.h>
 
@@ -340 +342 @@
 
 #if !RELEASE_LOG_DISABLED
+    constexpr size_t frameCountPerLog = 1800; // log every minute at 30 fps
+    if (!(m_frameRateMonitor.frameCount() % frameCountPerLog)) {
+        if (auto* metrics = [m_sampleBufferDisplayLayer videoPerformanceMetrics])
+            RELEASE_LOG(WebRTC, "LocalSampleBufferDisplayLayer (%{public}s) metrics, total=%lu, dropped=%lu, corrupted=%lu, display-composited=%lu, non-display-composited=%lu (pending=%lu)", m_logIdentifier.utf8().data(), metrics.totalNumberOfVideoFrames, metrics.numberOfDroppedVideoFrames, metrics.numberOfCorruptedVideoFrames, metrics.numberOfDisplayCompositedVideoFrames, metrics.numberOfNonDisplayCompositedVideoFrames, m_pendingVideoSampleQueue.size());
+    }
     m_frameRateMonitor.update();
 #endif