⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 282194 in webkit


Ignore:
Timestamp:
Sep 8, 2021, 11:56:55 PM (5 years ago)
Author:
youenn@apple.com
Message:

RTCPeerConnection.addIceCandidate takes an optional argument
​https://bugs.webkit.org/show_bug.cgi?id=229962

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt:
  • web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/WebCore:

Covered by rebased test.

  • Modules/mediastream/RTCPeerConnection.idl:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r282150 r282194  
     12021-09-08  Youenn Fablet  <youenn@apple.com>
     2
     3        RTCPeerConnection.addIceCandidate takes an optional argument
     4        https://bugs.webkit.org/show_bug.cgi?id=229962
     5
     6        Reviewed by Eric Carlson.
     7
     8        * web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt:
     9        * web-platform-tests/webrtc/idlharness.https.window-expected.txt:
     10
    1112021-09-08  Antti Koivisto  <antti@apple.com>
    212

  • trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt

    r281985 r282194  
    77PASS createAnswer must detect InvalidStateError synchronously when chain is empty (prerequisite)
    88FAIL SLD(rollback) must detect InvalidStateError synchronously when chain is empty assert_equals: promise rejected on same task expected "rejected" but got "pending"
    9 FAIL addIceCandidate must detect InvalidStateError synchronously when chain is empty assert_equals: expected "InvalidStateError" but got "TypeError"
     9FAIL addIceCandidate must detect InvalidStateError synchronously when chain is empty assert_equals: expected "InvalidStateError" but got "Error"
    1010PASS replaceTrack must detect InvalidStateError synchronously when chain is empty and transceiver is stopped
    1111PASS setParameters must detect InvalidStateError synchronously always when transceiver is stopped

  • trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/idlharness.https.window-expected.txt

    r282067 r282194  
    3333PASS RTCPeerConnection interface: attribute currentRemoteDescription
    3434PASS RTCPeerConnection interface: attribute pendingRemoteDescription
    35 FAIL RTCPeerConnection interface: operation addIceCandidate(optional RTCIceCandidateInit) assert_equals: property has wrong .length expected 0 but got 1
     35PASS RTCPeerConnection interface: operation addIceCandidate(optional RTCIceCandidateInit)
    3636PASS RTCPeerConnection interface: attribute signalingState
    3737PASS RTCPeerConnection interface: attribute iceGatheringState
    … …  
    5454PASS RTCPeerConnection interface: operation createAnswer(RTCSessionDescriptionCallback, RTCPeerConnectionErrorCallback)
    5555PASS RTCPeerConnection interface: operation setRemoteDescription(RTCSessionDescriptionInit, VoidFunction, RTCPeerConnectionErrorCallback)
    56 FAIL RTCPeerConnection interface: operation addIceCandidate(RTCIceCandidateInit, VoidFunction, RTCPeerConnectionErrorCallback) assert_equals: property has wrong .length expected 0 but got 1
     56PASS RTCPeerConnection interface: operation addIceCandidate(RTCIceCandidateInit, VoidFunction, RTCPeerConnectionErrorCallback)
    5757PASS RTCPeerConnection interface: operation generateCertificate(AlgorithmIdentifier)
    5858PASS RTCPeerConnection interface: operation getSenders()

  • trunk/Source/WebCore/ChangeLog

    r282193 r282194  
     12021-09-08  Youenn Fablet  <youenn@apple.com>
     2
     3        RTCPeerConnection.addIceCandidate takes an optional argument
     4        https://bugs.webkit.org/show_bug.cgi?id=229962
     5
     6        Reviewed by Eric Carlson.
     7
     8        Covered by rebased test.
     9
     10        * Modules/mediastream/RTCPeerConnection.idl:
     11
    1122021-09-08  Youenn Fablet  <youenn@apple.com>
    213

  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl

    r282067 r282194  
    9494    readonly attribute RTCSessionDescription? pendingRemoteDescription;
    9595
    96     Promise<undefined> addIceCandidate((RTCIceCandidateInit or RTCIceCandidate) candidate);
     96    Promise<undefined> addIceCandidate(optional (RTCIceCandidateInit or RTCIceCandidate) candidate);
    9797
    9898    readonly attribute RTCSignalingState signalingState;
Note: See TracChangeset for help on using the changeset viewer.