Changeset 282237 in webkit

Timestamp:

Sep 9, 2021, 1:05:16 PM (5 years ago)

Author:

Fujii Hironori

Message:

[Win] REGRESSION(r282123): some layout tests are failing because the bgcolor of text input forms are unexpectedly black
​https://bugs.webkit.org/show_bug.cgi?id=230077

Reviewed by Don Olmstead.

r282123 enabled HAVE_OS_DARK_MODE_SUPPORT for WinCairo. It uses
'-webkit-control-background' in the user-agent style sheet.
RenderThemeWin::systemColor always returned black for it. Because
WinCairo doesn't support dark mode yet, it is always light mode.
So, '-webkit-control-background' should be white at the moment.

• rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::systemColor const): Return white for CSSValueWebkitControlBackground.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderThemeWin.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win] REGRESSION(r282123): some layout tests are failing because the bgcolor of text input forms are unexpectedly black
+        https://bugs.webkit.org/show_bug.cgi?id=230077
+
+        Reviewed by Don Olmstead.
+
+        r282123 enabled HAVE_OS_DARK_MODE_SUPPORT for WinCairo. It uses
+        '-webkit-control-background' in the user-agent style sheet.
+        RenderThemeWin::systemColor always returned black for it. Because
+        WinCairo doesn't support dark mode yet, it is always light mode.
+        So, '-webkit-control-background' should be white at the moment.
+
+        * rendering/RenderThemeWin.cpp:
+        (WebCore::RenderThemeWin::systemColor const): Return white for CSSValueWebkitControlBackground.
+
 2021-09-09  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/rendering/RenderThemeWin.cpp

@@ -1005 +1005 @@
 Color RenderThemeWin::systemColor(CSSValueID cssValueId, OptionSet<StyleColor::Options> options) const
 {
+#if HAVE(OS_DARK_MODE_SUPPORT)
+    switch (cssValueId) {
+    case CSSValueWebkitControlBackground:
+        // FIXME: Dark mode isn't supported yet. https://webkit.org/b/230032
+        return Color::white;
+    }
+#endif
     int sysColorIndex = cssValueIdToSysColorIndex(cssValueId);
     if (sysColorIndex == -1)