Changeset 282380 in webkit

Timestamp:

Sep 14, 2021, 12:18:22 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Fix bug in calc functions sin/cos/tan
​https://bugs.webkit.org/show_bug.cgi?id=230133

Patch by Nikos Mouchtaris <Nikos Mouchtaris> on 2021-09-14
Reviewed by Myles Maxfield.

WPTs added in seperate patch: ​https://bugs.webkit.org/show_bug.cgi?id=230129.

• css/calc/CSSCalcOperationNode.cpp:

(WebCore::CSSCalcOperationNode::simplifyNode):
Fix bug where sin,cos,tan functions are applied twice when root.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/calc/CSSCalcOperationNode.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-14  Nikos Mouchtaris  <nmouchtaris@apple.com>
+
+        Fix bug in calc functions sin/cos/tan
+        https://bugs.webkit.org/show_bug.cgi?id=230133
+
+        Reviewed by Myles Maxfield.
+
+        WPTs added in seperate patch: https://bugs.webkit.org/show_bug.cgi?id=230129.
+
+        * css/calc/CSSCalcOperationNode.cpp:
+        (WebCore::CSSCalcOperationNode::simplifyNode):
+        Fix bug where sin,cos,tan functions are applied twice when root.
+
 2021-09-13  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/css/calc/CSSCalcOperationNode.cpp

@@ -646 +646 @@
             calcOperationNode.combineChildren();
         
-        if (calcOperationNode.isTrigNode())
+        if (calcOperationNode.isTrigNode() && depth)
             calcOperationNode.combineChildren();