Changeset 282383 in webkit

Timestamp:

Sep 14, 2021, 2:32:26 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r274929): [CoordinatedGraphics] DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor is no longer used
​https://bugs.webkit.org/show_bug.cgi?id=230214

Reviewed by Adrian Perez de Castro.

That means we use the right display refresh monitor in the threaded compositor but a different one for rendering
update scheduler.

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::displayRefreshMonitorFactory const): Remove platform ifdef, DrawingArea
unconditionally inherits from DisplayRefreshMonitorFactory and the default implementation of
createDisplayRefreshMonitor() returns nullptr.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebCoreSupport/WebChromeClient.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-09-14  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r274929): [CoordinatedGraphics] DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor is no longer used
+        https://bugs.webkit.org/show_bug.cgi?id=230214
+
+        Reviewed by Adrian Perez de Castro.
+
+        That means we use the right display refresh monitor in the threaded compositor but a different one for rendering
+        update scheduler.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::displayRefreshMonitorFactory const): Remove platform ifdef, DrawingArea
+        unconditionally inherits from DisplayRefreshMonitorFactory and the default implementation of
+        createDisplayRefreshMonitor() returns nullptr.
+
 2021-09-13  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp

@@ -924 +924 @@
 WebCore::DisplayRefreshMonitorFactory* WebChromeClient::displayRefreshMonitorFactory() const
 {
-#if PLATFORM(COCOA)
     return m_page.drawingArea();
-#else
-    return nullptr;
-#endif
 }