Changeset 282387 in webkit

Timestamp:

Sep 14, 2021, 6:49:12 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Remove unnecessary exception checks in DFGOperations
​https://bugs.webkit.org/show_bug.cgi?id=230247

Patch by Xan Lopez <Xan Lopez> on 2021-09-14
Reviewed by Caio Araujo Neponoceno de Lima.

JSValue::decode cannot throw an exception, remove a couple of
unnecessary RETURN_IF_EXCEPTION() calls.

• dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGOperations.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-09-14  Xan Lopez  <xan@igalia.com>
+
+        [JSC] Remove unnecessary exception checks in DFGOperations
+        https://bugs.webkit.org/show_bug.cgi?id=230247
+
+        Reviewed by Caio Araujo Neponoceno de Lima.
+
+        JSValue::decode cannot throw an exception, remove a couple of
+        unnecessary RETURN_IF_EXCEPTION() calls.
+
+        * dfg/DFGOperations.cpp:
+        (JSC::DFG::JSC_DEFINE_JIT_OPERATION):
+
 2021-09-14  Xan López  <xan@igalia.com>
 

trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

@@ -2531 +2531 @@
 
     JSValue base = JSValue::decode(baseValue);
-    RETURN_IF_EXCEPTION(scope, { });
     if (modeNumber == JSPropertyNameEnumerator::IndexedMode && base.isObject())
         RELEASE_AND_RETURN(scope, JSValue::encode(jsBoolean(jsCast<JSObject*>(base)->hasProperty(globalObject, index))));
@@ -2559 +2558 @@
 
     JSValue base = JSValue::decode(baseValue);
-    RETURN_IF_EXCEPTION(scope, { });
     if (modeNumber == JSPropertyNameEnumerator::IndexedMode && base.isObject())
         RELEASE_AND_RETURN(scope, JSValue::encode(jsBoolean(jsCast<JSObject*>(base)->hasOwnProperty(globalObject, index))));