⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 282408 in webkit


Ignore:
Timestamp:
Sep 14, 2021, 1:21:43 PM (5 years ago)
Author:
youenn@apple.com
Message:

Enable RTCRtpScriptTransform by default
​https://bugs.webkit.org/show_bug.cgi?id=230220
Source/WebCore:

Reviewed by Eric Carlson.

No change of behavior, renaming WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled
and WebRTCSFrameTransformEnabled.

  • Modules/mediastream/RTCEncodedAudioFrame.idl:
  • Modules/mediastream/RTCEncodedVideoFrame.idl:
  • Modules/mediastream/RTCRtpReceiver+Transform.idl:
  • Modules/mediastream/RTCRtpSFrameTransform.idl:
  • Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
  • Modules/mediastream/RTCRtpScriptTransform.idl:
  • Modules/mediastream/RTCRtpScriptTransformer.idl:
  • Modules/mediastream/RTCRtpSender+Transform.idl:
  • Modules/mediastream/RTCTransformEvent.idl:
  • workers/DedicatedWorkerGlobalScope.idl:

Source/WTF:

Reviewed by Eric Carlson.

Splitting WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled and WebRTCSFrameTransformEnabled.
Keeping WebRTCSFrameTransformEnabled as off by default until SFrame solidifies and mark WebRTCEncodedTransformEnabled as on by default.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

<rdar://problem/83090247>

Reviewed by Eric Carlson.

  • http/wpt/webrtc/no-webrtc-transform.html:

Migrate to new internal setting.

Location:
trunk
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r282407 r282408  
     12021-09-14  Youenn Fablet  <youenn@apple.com>
     2
     3        Enable RTCRtpScriptTransform by default
     4        https://bugs.webkit.org/show_bug.cgi?id=230220
     5        <rdar://problem/83090247>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * http/wpt/webrtc/no-webrtc-transform.html:
     10        Migrate to new internal setting.
     11
    1122021-09-14  Ayumi Kojima  <ayumi_kojima@apple.com>
    213

  • trunk/LayoutTests/http/wpt/webrtc/no-webrtc-transform.html

    r274385 r282408  
    1010promise_test(async (test) => {
    1111    if (window.internals)
    12         internals.settings.setWebRTCInsertableStreamsEnabled(true);
     12        internals.settings.setWebRTCEncodedTransformEnabled(true);
    1313
    1414    const worker = new Worker('no-transform.js');
    … …  
    1919promise_test(async (test) => {
    2020    if (window.internals)
    21         internals.settings.setWebRTCInsertableStreamsEnabled(false);
     21        internals.settings.setWebRTCEncodedTransformEnabled(false);
    2222
    2323    const worker = new Worker('no-transform.js');

  • trunk/Source/WTF/ChangeLog

    r282405 r282408  
     12021-09-14  Youenn Fablet  <youenn@apple.com>
     2
     3        Enable RTCRtpScriptTransform by default
     4        https://bugs.webkit.org/show_bug.cgi?id=230220
     5
     6        Reviewed by Eric Carlson.
     7
     8        Splitting  WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled and WebRTCSFrameTransformEnabled.
     9        Keeping WebRTCSFrameTransformEnabled as off by default until SFrame solidifies and mark WebRTCEncodedTransformEnabled as on by default.
     10
     11        * Scripts/Preferences/WebPreferencesExperimental.yaml:
     12
    1132021-09-14  Fujii Hironori  <Hironori.Fujii@sony.com>
    214

  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

    r282361 r282408  
    13931393      default: WebKit::defaultWebMParserEnabled()
    13941394
     1395WebRTCEncodedTransformEnabled:
     1396  type: bool
     1397  condition: ENABLE(WEB_RTC)
     1398  humanReadableName: "WebRTC Encoded Transform API"
     1399  humanReadableDescription: "Enable WebRTC Encoded Transform API"
     1400  defaultValue:
     1401    WebKitLegacy:
     1402      default: false
     1403    WebKit:
     1404      default: true
     1405    WebCore:
     1406      default: true
     1407
    13951408# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
    13961409WebRTCH264LowLatencyEncoderEnabled:
    … …  
    14191432      default: false
    14201433
    1421 WebRTCInsertableStreamsEnabled:
    1422   type: bool
    1423   condition: ENABLE(WEB_RTC)
    1424   humanReadableName: "WebRTC Insertable Streams API"
    1425   humanReadableDescription: "Enable WebRTC Insertable Streams API"
    1426   defaultValue:
    1427     WebKitLegacy:
    1428       default: false
    1429     WebKit:
    1430       default: false
    1431     WebCore:
    1432       default: false
    1433 
    14341434# FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
    14351435WebRTCPlatformCodecsInGPUProcessEnabled:
    … …  
    14661466      default: true
    14671467
     1468WebRTCSFrameTransformEnabled:
     1469  type: bool
     1470  condition: ENABLE(WEB_RTC)
     1471  humanReadableName: "WebRTC SFrame Transform API"
     1472  humanReadableDescription: "Enable WebRTC SFrame Transform API"
     1473  defaultValue:
     1474    WebKitLegacy:
     1475      default: false
     1476    WebKit:
     1477      default: false
     1478    WebCore:
     1479      default: false
     1480
    14681481WebRTCSocketsProxyingEnabled:
    14691482  type: bool

  • trunk/Source/WebCore/ChangeLog

    r282403 r282408  
     12021-09-14  Youenn Fablet  <youenn@apple.com>
     2
     3        Enable RTCRtpScriptTransform by default
     4        https://bugs.webkit.org/show_bug.cgi?id=230220
     5
     6        Reviewed by Eric Carlson.
     7
     8        No change of behavior, renaming WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled
     9        and WebRTCSFrameTransformEnabled.
     10
     11        * Modules/mediastream/RTCEncodedAudioFrame.idl:
     12        * Modules/mediastream/RTCEncodedVideoFrame.idl:
     13        * Modules/mediastream/RTCRtpReceiver+Transform.idl:
     14        * Modules/mediastream/RTCRtpSFrameTransform.idl:
     15        * Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
     16        * Modules/mediastream/RTCRtpScriptTransform.idl:
     17        * Modules/mediastream/RTCRtpScriptTransformer.idl:
     18        * Modules/mediastream/RTCRtpSender+Transform.idl:
     19        * Modules/mediastream/RTCTransformEvent.idl:
     20        * workers/DedicatedWorkerGlobalScope.idl:
     21
    1222021-09-14  Darin Adler  <darin@apple.com>
    223

  • trunk/Source/WebCore/Modules/mediastream/RTCEncodedAudioFrame.idl

    r275830 r282408  
    3535[
    3636    Conditional=WEB_RTC,
    37     EnabledBySetting=WebRTCInsertableStreams,
     37    EnabledBySetting=WebRTCEncodedTransform,
    3838    Exposed=DedicatedWorker,
    3939    ImplementationLacksVTable,

  • trunk/Source/WebCore/Modules/mediastream/RTCEncodedVideoFrame.idl

    r276018 r282408  
    4444[
    4545    Conditional=WEB_RTC,
    46     EnabledBySetting=WebRTCInsertableStreams,
     46    EnabledBySetting=WebRTCEncodedTransform,
    4747    Exposed=DedicatedWorker,
    4848    ImplementationLacksVTable,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver+Transform.idl

    r274832 r282408  
    2828[
    2929    Conditional=WEB_RTC,
    30     EnabledBySetting=WebRTCInsertableStreams,
     30    EnabledBySetting=WebRTCEncodedTransform,
    3131    Exposed=Window,
    3232    ImplementedBy=RTCRtpReceiverWithTransform,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.idl

    r280958 r282408  
    4444    ActiveDOMObject,
    4545    Conditional=WEB_RTC,
    46     EnabledBySetting=WebRTCInsertableStreams,
     46    EnabledBySetting=WebRTCSFrameTransform,
    4747    ExportMacro=WEBCORE_EXPORT,
    4848    Exposed=(Window,DedicatedWorker),

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl

    r280958 r282408  
    3737[
    3838    Conditional=WEB_RTC,
    39     EnabledBySetting=WebRTCInsertableStreams,
     39    EnabledBySetting=WebRTCSFrameTransform,
    4040    Exposed=(Window,DedicatedWorker),
    4141    InterfaceName=SFrameTransformErrorEvent

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl

    r276013 r282408  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_RTC,
    29     EnabledBySetting=WebRTCInsertableStreams,
     29    EnabledBySetting=WebRTCEncodedTransform,
    3030    Exposed=Window,
    3131    JSGenerateToNativeObject,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.idl

    r276013 r282408  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_RTC,
    29     EnabledBySetting=WebRTCInsertableStreams,
     29    EnabledBySetting=WebRTCEncodedTransform,
    3030    Exposed=DedicatedWorker,
    3131    JSGenerateToNativeObject,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpSender+Transform.idl

    r274832 r282408  
    2828[
    2929    Conditional=WEB_RTC,
    30     EnabledBySetting=WebRTCInsertableStreams,
     30    EnabledBySetting=WebRTCEncodedTransform,
    3131    Exposed=Window,
    3232    ImplementedBy=RTCRtpSenderWithTransform,

  • trunk/Source/WebCore/Modules/mediastream/RTCTransformEvent.idl

    r274385 r282408  
    2525[
    2626    Conditional=WEB_RTC,
    27     EnabledBySetting=WebRTCInsertableStreams,
     27    EnabledBySetting=WebRTCEncodedTransform,
    2828    Exposed=Worker,
    2929    InterfaceName=RTCTransformEvent,

  • trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl

    r281808 r282408  
    4747
    4848[Conditional=OFFSCREEN_CANVAS_IN_WORKERS, EnabledAtRuntime=OffscreenCanvasInWorkers] DedicatedWorkerGlobalScope includes AnimationFrameProvider;
    49 [Conditional=WEB_RTC, EnabledBySetting=WebRTCInsertableStreams] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
     49[Conditional=WEB_RTC, EnabledBySetting=WebRTCEncodedTransform] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
Note: See TracChangeset for help on using the changeset viewer.