Changeset 282438 in webkit

Timestamp:

Sep 14, 2021, 10:38:27 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=203508

Patch by Rob Buis <​rbuis@igalia.com> on 2021-09-14
Reviewed by Simon Fraser.

Source/WebCore:

For replaced elements like images, non specified min/max logical widths are a
reason for re-layout after intrinsic size change (for example min-width: min-content).

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):

LayoutTests:

• TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderReplaced.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-09-14  Rob Buis  <rbuis@igalia.com>
+
+        imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change* tests fail
+        https://bugs.webkit.org/show_bug.cgi?id=203508
+
+        Reviewed by Simon Fraser.
+
+        * TestExpectations:
+
 2021-09-14  Eric Hutchison  <ehutchison@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -3416 +3416 @@
 webkit.org/b/203510 imported/w3c/web-platform-tests/css/css-sizing/clone-intrinsic-size.html [ ImageOnlyFailure ]
 webkit.org/b/203511 imported/w3c/web-platform-tests/css/css-sizing/clone-nowrap-intrinsic-size-bidi.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-001.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-002.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-003.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-004.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-005.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-006.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-007.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-008.html [ ImageOnlyFailure ]
 webkit.org/b/203512 imported/w3c/web-platform-tests/css/css-sizing/intrinsic-percent-non-replaced-004.html [ ImageOnlyFailure ]
 webkit.org/b/203512 imported/w3c/web-platform-tests/css/css-sizing/intrinsic-percent-non-replaced-005.html [ ImageOnlyFailure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-14  Rob Buis  <rbuis@igalia.com>
+
+        imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change* tests fail
+        https://bugs.webkit.org/show_bug.cgi?id=203508
+
+        Reviewed by Simon Fraser.
+
+        For replaced elements like images, non specified min/max logical widths are a
+        reason for re-layout after intrinsic size change (for example min-width: min-content).
+
+        * rendering/RenderReplaced.cpp:
+        (WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):
+
 2021-09-14  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/WebCore/rendering/RenderReplaced.cpp

@@ -374 +374 @@
     
     // If the actual area occupied by the image has changed and it is not constrained by style then a layout is required.
-    bool imageSizeIsConstrained = style().logicalWidth().isSpecified() && style().logicalHeight().isSpecified();
+    bool imageSizeIsConstrained = style().logicalWidth().isSpecified() && style().logicalHeight().isSpecified() && !style().logicalMinWidth().isIntrinsic() && !style().logicalMaxWidth().isIntrinsic();
     
     // FIXME: We only need to recompute the containing block's preferred size