Changeset 282452 in webkit

Timestamp:

Sep 15, 2021, 7:21:49 AM (5 years ago)

Author:

Antti Koivisto

Message:

[LFC][Integration] TextBoxSelectableRange::additionalLengthAtEnd miscomputed
​https://bugs.webkit.org/show_bug.cgi?id=230306

Reviewed by Alan Bujtas.

It should be non-zero only if the run contains a hyphen. This doesn't yet affect
anything, but it will.

• layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::selectableRange const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/integration/LayoutIntegrationRunIteratorModernPath.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-15  Antti Koivisto  <antti@apple.com>
+
+        [LFC][Integration] TextBoxSelectableRange::additionalLengthAtEnd miscomputed
+        https://bugs.webkit.org/show_bug.cgi?id=230306
+
+        Reviewed by Alan Bujtas.
+
+        It should be non-zero only if the run contains a hyphen. This doesn't yet affect
+        anything, but it will.
+
+        * layout/integration/LayoutIntegrationRunIteratorModernPath.h:
+        (WebCore::LayoutIntegration::RunIteratorModernPath::selectableRange const):
+
 2021-09-15  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h

@@ -106 +106 @@
             start(),
             length(),
-            run().style().hyphenString().length(),
+            run().text()->hasHyphen() ? run().style().hyphenString().length() : 0,
             run().isLineBreak()
         };