Changeset 282465 in webkit

Timestamp:

Sep 15, 2021, 12:52:18 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Cache resource paths in run-jsc-stress-tests for speedup
​https://bugs.webkit.org/show_bug.cgi?id=230263

Patch by Geza Lore <​gezalore@gmail.com> on 2021-09-15
Reviewed by Adrian Perez de Castro.

A large portion of the serial startup time of run-jsc-stress-tests is
just re-computing file system paths of bundle resources over and over
again. Cache results for a 40% speedup of the test enumeration phase.

• Scripts/run-jsc-stress-tests:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-jsc-stress-tests (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-09-15  Geza Lore  <gezalore@gmail.com>
+
+        Cache resource paths in run-jsc-stress-tests for speedup
+        https://bugs.webkit.org/show_bug.cgi?id=230263
+
+        Reviewed by Adrian Perez de Castro.
+
+        A large portion of the serial startup time of run-jsc-stress-tests is
+        just re-computing file system paths of bundle resources over and over
+        again. Cache results for a 40% speedup of the test enumeration phase.
+
+        * Scripts/run-jsc-stress-tests:
+
 2021-09-14  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Tools/Scripts/run-jsc-stress-tests

@@ -588 +588 @@
 end
 
+
+# Frequently repeated path computations. Cache results for speed.
+$bundleResourcePathCache = Hash.new do |h, key|
+    resourcePath, benchmarkDirectory, dir = key
+    benchmarkDirectory.each_filename {
+        | pathComponent |
+        dir = dir.parent
+    }
+    h[key] = dir + resourcePath
+end
+
 def pathToBundleResourceFromBenchmarkDirectory(resourcePath)
-    dir = Pathname.new(".")
-    $benchmarkDirectory.each_filename {
-        | pathComponent |
-        dir += ".."
-    }
-    dir + resourcePath
+    $bundleResourcePathCache[[resourcePath, $benchmarkDirectory, Pathname.new(".")]]
 end