Changeset 282469 in webkit

Timestamp:

Sep 15, 2021, 1:18:25 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Avoid GCC warnings introduced in r282125
​https://bugs.webkit.org/show_bug.cgi?id=230154

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-09-15
Reviewed by Fujii Hironori.

Yusuke suggested casting to UChar to avoid -Wswitch-out-of-range. This works!

Also, avoid -Wredundant-move by removing one unnecessary WTFMove.

• runtime/ISO8601.cpp:

(JSC::ISO8601::parseTimeZoneBracketedAnnotation):
(JSC::ISO8601::canBeTimeZone):
(JSC::ISO8601::parseTimeZone):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/ISO8601.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-09-15  Michael Catanzaro  <mcatanzaro@gnome.org>
+
+        Avoid GCC warnings introduced in r282125
+        https://bugs.webkit.org/show_bug.cgi?id=230154
+
+        Reviewed by Fujii Hironori.
+
+        Yusuke suggested casting to UChar to avoid -Wswitch-out-of-range. This works!
+
+        Also, avoid -Wredundant-move by removing one unnecessary WTFMove.
+
+        * runtime/ISO8601.cpp:
+        (JSC::ISO8601::parseTimeZoneBracketedAnnotation):
+        (JSC::ISO8601::canBeTimeZone):
+        (JSC::ISO8601::parseTimeZone):
+
 2021-09-15  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/runtime/ISO8601.cpp

@@ -449 +449 @@
     buffer.advance();
 
-    switch (*buffer) {
+    switch (static_cast<UChar>(*buffer)) {
     case '+':
     case '-':
@@ -577 +577 @@
             return std::nullopt;
         buffer.advance();
-        return WTFMove(result);
+        return result;
     }
     }
@@ -585 +585 @@
 static bool canBeTimeZone(const StringParsingBuffer<CharacterType>& buffer, CharacterType character)
 {
-    switch (character) {
+    switch (static_cast<UChar>(character)) {
     // UTCDesignator
     // https://tc39.es/proposal-temporal/#prod-UTCDesignator
@@ -616 +616 @@
     if (buffer.atEnd())
         return std::nullopt;
-    switch (*buffer) {
+    switch (static_cast<UChar>(*buffer)) {
     // UTCDesignator
     // https://tc39.es/proposal-temporal/#prod-UTCDesignator