Changeset 282477 in webkit

Timestamp:

Sep 15, 2021, 3:12:01 PM (5 years ago)

Author:

Patrick Angle

Message:

Web Inspector: TreeOutline should return early when failing to find an ancestor while populating the tree
​https://bugs.webkit.org/show_bug.cgi?id=230287

Reviewed by Devin Rousso.

When an ancestor can not be found, we should return to prevent additional work (which will fail) from being done.

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.findTreeElement):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TreeOutline.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-09-15  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: `TreeOutline` should return early when failing to find an ancestor while populating the tree
+        https://bugs.webkit.org/show_bug.cgi?id=230287
+
+        Reviewed by Devin Rousso.
+
+        When an ancestor can not be found, we should return to prevent additional work (which will fail) from being done.
+
+        * UserInterface/Views/TreeOutline.js:
+        (WI.TreeOutline.prototype.findTreeElement):
+
 2021-09-15  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

@@ -517 +517 @@
             // ancestor exists in the tree.
             item = this.findTreeElement(ancestors[i], isAncestor, getParent);
-            if (item)
-                item.onpopulate();
+            if (!item)
+                return null;
+
+            item.onpopulate();
         }