Changeset 282482 in webkit

Timestamp:

Sep 15, 2021, 5:26:33 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Remove the "core.webKitBranchBuild" prompt from setup-git-clone
​https://bugs.webkit.org/show_bug.cgi?id=230323

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/tool/commands/setupgitclone.py:

(SetupGitClone.execute):
"core.webKitBranchBuild" is an advanced feature and also doesn't work
at all for Apple folks (leading to a myriad of bizarro build problems).
Folks who want it can use the documentation (UsingGitWithWebKit on the Wiki),
but in general, until it's well supported, it's best if we don't encourage it.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/setupgitclone.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-09-15  Tim Horton  <timothy_horton@apple.com>
+
+        Remove the "core.webKitBranchBuild" prompt from setup-git-clone
+        https://bugs.webkit.org/show_bug.cgi?id=230323
+
+        Reviewed by Jonathan Bedard.
+
+        * Scripts/webkitpy/tool/commands/setupgitclone.py:
+        (SetupGitClone.execute):
+        "core.webKitBranchBuild" is an advanced feature and also doesn't work
+        at all for Apple folks (leading to a myriad of bizarro build problems).
+        Folks who want it can use the documentation (UsingGitWithWebKit on the Wiki),
+        but in general, until it's well supported, it's best if we don't encourage it.
+
 2021-09-15  Geza Lore  <gezalore@gmail.com>
 

trunk/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py

@@ -74 +74 @@
             run_git(["config", "merge.changelog.driver", "perl Tools/Scripts/resolve-ChangeLogs --fix-merged --merge-driver %O %B %A"])
 
-        if tool.user.confirm("Do you want to append the git branch name to every build? (e.g. WebKitBuild/mybranch/; y/n)"):
-            run_git(["config", "core.webKitBranchBuild", "true"])
-            print("You can override this option via git config branch.$branchName.webKitBranchBuild (true|false)")
-
         print("Done")