Changeset 282490 in webkit

Timestamp:

Sep 16, 2021, 12:33:58 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK][WPE] test animations/steps-transform-rendering-updates.html fails
​https://bugs.webkit.org/show_bug.cgi?id=230307

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-09-16
Reviewed by Carlos Alberto Lopez Perez.

ThreadedDisplayRefreshMonitor is not setting isScheduled back to false when it's fired. That causes
hasBeenRescheduled to be true and handleDisplayRefreshMonitorUpdate() is called with force repaint option, so we
end up flushing layers on every display refresh update.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][WPE] test animations/steps-transform-rendering-updates.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=230307
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        ThreadedDisplayRefreshMonitor is not setting isScheduled back to false when it's fired. That causes
+        hasBeenRescheduled to be true and handleDisplayRefreshMonitorUpdate() is called with force repaint option, so we
+        end up flushing layers on every display refresh update.
+
+        * Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
+        (WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):
+
 2021-09-15  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp

@@ -109 +109 @@
         Locker locker { lock() };
         shouldHandleDisplayRefreshNotification = isScheduled() && isPreviousFrameDone();
-        if (shouldHandleDisplayRefreshNotification)
+        if (shouldHandleDisplayRefreshNotification) {
+            setIsScheduled(false);
             setIsPreviousFrameDone(false);
+        }
     }