Changeset 282494 in webkit

Timestamp:

Sep 16, 2021, 12:41:10 AM (5 years ago)

Author:

youenn@apple.com

Message:

Use libwebrtc OnStandardizedIceConnectionChange callback instead of OnIceConnectionChange
​https://bugs.webkit.org/show_bug.cgi?id=230314

Reviewed by Eric Carlson.

Migrate to standardized variant.
Covered by existing tests.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::OnStandardizedIceConnectionChange):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (modified) (1 diff)
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-16  Youenn Fablet  <youenn@apple.com>
+
+        Use libwebrtc OnStandardizedIceConnectionChange callback instead of OnIceConnectionChange
+        https://bugs.webkit.org/show_bug.cgi?id=230314
+
+        Reviewed by Eric Carlson.
+
+        Migrate to standardized variant.
+        Covered by existing tests.
+
+        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+        (WebCore::LibWebRTCMediaEndpoint::OnStandardizedIceConnectionChange):
+        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
+
 2021-09-15  Philip Chimento  <pchimento@igalia.com>
 

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp

@@ -522 +522 @@
 }
 
-void LibWebRTCMediaEndpoint::OnIceConnectionChange(webrtc::PeerConnectionInterface::IceConnectionState state)
+void LibWebRTCMediaEndpoint::OnStandardizedIceConnectionChange(webrtc::PeerConnectionInterface::IceConnectionState state)
 {
     auto connectionState = toRTCIceConnectionState(state);

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h

@@ -129 +129 @@
 
     void OnNegotiationNeededEvent(uint32_t) final;
-    void OnIceConnectionChange(webrtc::PeerConnectionInterface::IceConnectionState) final;
+    void OnStandardizedIceConnectionChange(webrtc::PeerConnectionInterface::IceConnectionState) final;
     void OnIceGatheringChange(webrtc::PeerConnectionInterface::IceGatheringState) final;
     void OnIceCandidate(const webrtc::IceCandidateInterface*) final;