Changeset 282499 in webkit

Timestamp:

Sep 16, 2021, 1:00:25 AM (5 years ago)

Author:

Adrian Perez de Castro

Message:

Merge r275807 - Store InputType in a Ref before calling setValueAsDecimal
​https://bugs.webkit.org/show_bug.cgi?id=223535

Patch by Rob Buis <​rbuis@igalia.com> on 2021-04-11
Reviewed by Ryosuke Niwa.

Store InputType in a Ref before calling setValueAsDecimal.

• html/InputType.cpp:

(WebCore::InputType::applyStep):

Location:

releases/WebKitGTK/webkit-2.32/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/InputType.cpp (modified) (1 diff)

releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-11  Rob Buis  <rbuis@igalia.com>
+
+        Store InputType in a Ref before calling setValueAsDecimal
+        https://bugs.webkit.org/show_bug.cgi?id=223535
+
+        Reviewed by Ryosuke Niwa.
+
+        Store InputType in a Ref before calling setValueAsDecimal.
+
+        * html/InputType.cpp:
+        (WebCore::InputType::applyStep):
+
 2021-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
 

releases/WebKitGTK/webkit-2.32/Source/WebCore/html/InputType.cpp

@@ -930 +930 @@
         newValue = stepRange.maximum();
 
+    auto protectedThis = makeRef(*this);
     auto result = setValueAsDecimal(newValue, eventBehavior);
-    if (result.hasException())
+    if (result.hasException() || !element())
         return result;