Changeset 282501 in webkit

Timestamp:

Sep 16, 2021, 1:09:11 AM (5 years ago)

Author:

Adrian Perez de Castro

Message:

Merge r275876 - Skip style update
​https://bugs.webkit.org/show_bug.cgi?id=223365

Patch by Rob Buis <​rbuis@igalia.com> on 2021-04-13
Reviewed by Ryosuke Niwa.

Skip style update for getting the SVG bounding box
since boundingClientRect already updated style.

• dom/Element.cpp:

(WebCore::Element::boundingAbsoluteRectWithoutLayout):

• svg/SVGElement.cpp:

(WebCore::SVGElement::getBoundingBox):

Location:

releases/WebKitGTK/webkit-2.32/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (1 diff)
• svg/SVGElement.cpp (modified) (1 diff)

releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-13  Rob Buis  <rbuis@igalia.com>
+
+        Skip style update
+        https://bugs.webkit.org/show_bug.cgi?id=223365
+
+        Reviewed by Ryosuke Niwa.
+
+        Skip style update for getting the SVG bounding box
+        since boundingClientRect already updated style.
+
+        * dom/Element.cpp:
+        (WebCore::Element::boundingAbsoluteRectWithoutLayout):
+        * svg/SVGElement.cpp:
+        (WebCore::SVGElement::getBoundingBox):
+
 2021-04-12  BJ Burg  <bburg@apple.com>
 

releases/WebKitGTK/webkit-2.32/Source/WebCore/dom/Element.cpp

@@ -1614 +1614 @@
         SVGElement& svgElement = downcast<SVGElement>(*this);
         FloatRect localRect;
-        if (svgElement.getBoundingBox(localRect))
+        if (svgElement.getBoundingBox(localRect, SVGLocatable::DisallowStyleUpdate))
             quads.append(renderer->localToAbsoluteQuad(localRect));
     } else if (auto pair = listBoxElementBoundingBox(*this)) {

releases/WebKitGTK/webkit-2.32/Source/WebCore/svg/SVGElement.cpp

@@ -294 +294 @@
 bool SVGElement::getBoundingBox(FloatRect& rect, SVGLocatable::StyleUpdateStrategy styleUpdateStrategy)
 {
+    // FIXME: should retrieve the value from the associated RenderObject.
     if (is<SVGGraphicsElement>(*this)) {
         rect = downcast<SVGGraphicsElement>(*this).getBBox(styleUpdateStrategy);