Changeset 282512 in webkit

Timestamp:

Sep 16, 2021, 1:51:23 AM (5 years ago)

Author:

Adrian Perez de Castro

Message:

Merge r276630 - [MathML] Assertion failure in RenderTreeNeedsLayoutChecker
​https://bugs.webkit.org/show_bug.cgi?id=224903

Patch by Frédéric Wang <​fwang@igalia.com> on 2021-04-27
Reviewed by Alan Bujtas.

Source/WebCore:

After r226180, RenderMathMLRow no longer performs layout of its "embellished operator"
children only its core <mo> descendant, which is causing dirty layout.

Test: mathml/vertical-embellished-op-dirty-layout.html

• rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::stretchVerticalOperatorsAndLayoutChildren): always layout the
"embellished operator" child, after its core <mo>.

LayoutTests:

Add regression test with all vertical embellished operators (other than <mo>) supported
by WebKit.

• mathml/vertical-embellished-op-dirty-layout-expected.txt: Added.
• mathml/vertical-embellished-op-dirty-layout.html: Added.

Location:

releases/WebKitGTK/webkit-2.32

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/mathml/vertical-embellished-op-dirty-layout-expected.txt (added)
• LayoutTests/mathml/vertical-embellished-op-dirty-layout.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/mathml/RenderMathMLRow.cpp (modified) (1 diff)

releases/WebKitGTK/webkit-2.32/LayoutTests/ChangeLog

@@ +1 @@
+2021-04-27  Frédéric Wang  <fwang@igalia.com>
+
+        [MathML] Assertion failure in RenderTreeNeedsLayoutChecker
+        https://bugs.webkit.org/show_bug.cgi?id=224903
+
+        Reviewed by Alan Bujtas.
+
+        Add regression test with all vertical embellished operators (other than <mo>) supported
+        by WebKit.
+
+        * mathml/vertical-embellished-op-dirty-layout-expected.txt: Added.
+        * mathml/vertical-embellished-op-dirty-layout.html: Added.
+
 2021-04-19  Darin Adler  <darin@apple.com>
 

releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-27  Frédéric Wang  <fwang@igalia.com>
+
+        [MathML] Assertion failure in RenderTreeNeedsLayoutChecker
+        https://bugs.webkit.org/show_bug.cgi?id=224903
+
+        Reviewed by Alan Bujtas.
+
+        After r226180, RenderMathMLRow no longer performs layout of its "embellished operator"
+        children only its core <mo> descendant, which is causing dirty layout.
+
+        Test: mathml/vertical-embellished-op-dirty-layout.html
+
+        * rendering/mathml/RenderMathMLRow.cpp:
+        (WebCore::RenderMathMLRow::stretchVerticalOperatorsAndLayoutChildren): always layout the
+        "embellished operator" child, after its core <mo>.
+
 2021-04-23  Ian Gilbert  <iang@apple.com>
 

releases/WebKitGTK/webkit-2.32/Source/WebCore/rendering/mathml/RenderMathMLRow.cpp

@@ -102 +102 @@
             renderOperator->stretchTo(stretchAscent, stretchDescent);
             renderOperator->layoutIfNeeded();
+            child->layoutIfNeeded();
         }
     }