⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 282523 in webkit


Ignore:
Timestamp:
Sep 16, 2021, 2:55:12 AM (5 years ago)
Author:
youenn@apple.com
Message:

Enable RTCRtpScriptTransform by default
​https://bugs.webkit.org/show_bug.cgi?id=230220
Source/WebCore:

Reviewed by Eric Carlson.

No change of behavior, renaming WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled
and WebRTCSFrameTransformEnabled.

  • Modules/mediastream/RTCEncodedAudioFrame.idl:
  • Modules/mediastream/RTCEncodedVideoFrame.idl:
  • Modules/mediastream/RTCRtpReceiver+Transform.idl:
  • Modules/mediastream/RTCRtpSFrameTransform.idl:
  • Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
  • Modules/mediastream/RTCRtpScriptTransform.idl:
  • Modules/mediastream/RTCRtpScriptTransformer.idl:
  • Modules/mediastream/RTCRtpSender+Transform.idl:
  • Modules/mediastream/RTCTransformEvent.idl:
  • workers/DedicatedWorkerGlobalScope.idl:

Source/WTF:

Reviewed by Eric Carlson.

Splitting WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled and WebRTCSFrameTransformEnabled.
Keeping WebRTCSFrameTransformEnabled as off by default until SFrame solidifies and mark WebRTCEncodedTransformEnabled as on by default.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

<rdar://problem/83090247>

Reviewed by Eric Carlson.

  • http/wpt/webrtc/no-webrtc-transform.html:

Migrate to new internal setting.

Location:
trunk
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r282513 r282523  
     12021-09-16  Youenn Fablet  <youenn@apple.com>
     2
     3        Enable RTCRtpScriptTransform by default
     4        https://bugs.webkit.org/show_bug.cgi?id=230220
     5        <rdar://problem/83090247>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * http/wpt/webrtc/no-webrtc-transform.html:
     10        Migrate to new internal setting.
     11
    1122021-09-16  Cameron McCormack  <heycam@apple.com>
    213

  • trunk/LayoutTests/http/wpt/webrtc/no-webrtc-transform.html

    r282416 r282523  
    1010promise_test(async (test) => {
    1111    if (window.internals)
    12         internals.settings.setWebRTCInsertableStreamsEnabled(true);
     12        internals.settings.setWebRTCEncodedTransformEnabled(true);
    1313
    1414    const worker = new Worker('no-transform.js');
    … …  
    1919promise_test(async (test) => {
    2020    if (window.internals)
    21         internals.settings.setWebRTCInsertableStreamsEnabled(false);
     21        internals.settings.setWebRTCEncodedTransformEnabled(false);
    2222
    2323    const worker = new Worker('no-transform.js');

  • trunk/Source/WTF/ChangeLog

    r282513 r282523  
     12021-09-16  Youenn Fablet  <youenn@apple.com>
     2
     3        Enable RTCRtpScriptTransform by default
     4        https://bugs.webkit.org/show_bug.cgi?id=230220
     5
     6        Reviewed by Eric Carlson.
     7
     8        Splitting  WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled and WebRTCSFrameTransformEnabled.
     9        Keeping WebRTCSFrameTransformEnabled as off by default until SFrame solidifies and mark WebRTCEncodedTransformEnabled as on by default.
     10
     11        * Scripts/Preferences/WebPreferencesExperimental.yaml:
     12
    1132021-09-16  Cameron McCormack  <heycam@apple.com>
    214

  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

    r282487 r282523  
    14041404      default: WebKit::defaultWebMParserEnabled()
    14051405
     1406WebRTCEncodedTransformEnabled:
     1407  type: bool
     1408  condition: ENABLE(WEB_RTC)
     1409  humanReadableName: "WebRTC Encoded Transform API"
     1410  humanReadableDescription: "Enable WebRTC Encoded Transform API"
     1411  defaultValue:
     1412    WebKitLegacy:
     1413      default: false
     1414    WebKit:
     1415      default: true
     1416    WebCore:
     1417      default: true
     1418
    14061419# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
    14071420WebRTCH264LowLatencyEncoderEnabled:
    … …  
    14301443      default: false
    14311444
    1432 WebRTCInsertableStreamsEnabled:
    1433   type: bool
    1434   condition: ENABLE(WEB_RTC)
    1435   humanReadableName: "WebRTC Insertable Streams API"
    1436   humanReadableDescription: "Enable WebRTC Insertable Streams API"
    1437   defaultValue:
    1438     WebKitLegacy:
    1439       default: false
    1440     WebKit:
    1441       default: false
    1442     WebCore:
    1443       default: false
    1444 
    14451445# FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
    14461446WebRTCPlatformCodecsInGPUProcessEnabled:
    … …  
    14771477      default: true
    14781478
     1479WebRTCSFrameTransformEnabled:
     1480  type: bool
     1481  condition: ENABLE(WEB_RTC)
     1482  humanReadableName: "WebRTC SFrame Transform API"
     1483  humanReadableDescription: "Enable WebRTC SFrame Transform API"
     1484  defaultValue:
     1485    WebKitLegacy:
     1486      default: false
     1487    WebKit:
     1488      default: false
     1489    WebCore:
     1490      default: false
     1491
    14791492WebRTCSocketsProxyingEnabled:
    14801493  type: bool

  • trunk/Source/WebCore/ChangeLog

    r282513 r282523  
     12021-09-16  Youenn Fablet  <youenn@apple.com>
     2
     3        Enable RTCRtpScriptTransform by default
     4        https://bugs.webkit.org/show_bug.cgi?id=230220
     5
     6        Reviewed by Eric Carlson.
     7
     8        No change of behavior, renaming WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled
     9        and WebRTCSFrameTransformEnabled.
     10
     11        * Modules/mediastream/RTCEncodedAudioFrame.idl:
     12        * Modules/mediastream/RTCEncodedVideoFrame.idl:
     13        * Modules/mediastream/RTCRtpReceiver+Transform.idl:
     14        * Modules/mediastream/RTCRtpSFrameTransform.idl:
     15        * Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
     16        * Modules/mediastream/RTCRtpScriptTransform.idl:
     17        * Modules/mediastream/RTCRtpScriptTransformer.idl:
     18        * Modules/mediastream/RTCRtpSender+Transform.idl:
     19        * Modules/mediastream/RTCTransformEvent.idl:
     20        * workers/DedicatedWorkerGlobalScope.idl:
     21
    1222021-09-16  Cameron McCormack  <heycam@apple.com>
    223

  • trunk/Source/WebCore/Modules/mediastream/RTCEncodedAudioFrame.idl

    r282416 r282523  
    3535[
    3636    Conditional=WEB_RTC,
    37     EnabledBySetting=WebRTCInsertableStreams,
     37    EnabledBySetting=WebRTCEncodedTransform,
    3838    Exposed=DedicatedWorker,
    3939    ImplementationLacksVTable,

  • trunk/Source/WebCore/Modules/mediastream/RTCEncodedVideoFrame.idl

    r282416 r282523  
    4444[
    4545    Conditional=WEB_RTC,
    46     EnabledBySetting=WebRTCInsertableStreams,
     46    EnabledBySetting=WebRTCEncodedTransform,
    4747    Exposed=DedicatedWorker,
    4848    ImplementationLacksVTable,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver+Transform.idl

    r282416 r282523  
    2828[
    2929    Conditional=WEB_RTC,
    30     EnabledBySetting=WebRTCInsertableStreams,
     30    EnabledBySetting=WebRTCEncodedTransform,
    3131    Exposed=Window,
    3232    ImplementedBy=RTCRtpReceiverWithTransform,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.idl

    r282416 r282523  
    4444    ActiveDOMObject,
    4545    Conditional=WEB_RTC,
    46     EnabledBySetting=WebRTCInsertableStreams,
     46    EnabledBySetting=WebRTCSFrameTransform,
    4747    ExportMacro=WEBCORE_EXPORT,
    4848    Exposed=(Window,DedicatedWorker),

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl

    r282416 r282523  
    3737[
    3838    Conditional=WEB_RTC,
    39     EnabledBySetting=WebRTCInsertableStreams,
     39    EnabledBySetting=WebRTCSFrameTransform,
    4040    Exposed=(Window,DedicatedWorker),
    4141    InterfaceName=SFrameTransformErrorEvent

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl

    r282416 r282523  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_RTC,
    29     EnabledBySetting=WebRTCInsertableStreams,
     29    EnabledBySetting=WebRTCEncodedTransform,
    3030    Exposed=Window,
    3131    JSGenerateToNativeObject,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.idl

    r282416 r282523  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_RTC,
    29     EnabledBySetting=WebRTCInsertableStreams,
     29    EnabledBySetting=WebRTCEncodedTransform,
    3030    Exposed=DedicatedWorker,
    3131    JSGenerateToNativeObject,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpSender+Transform.idl

    r282416 r282523  
    2828[
    2929    Conditional=WEB_RTC,
    30     EnabledBySetting=WebRTCInsertableStreams,
     30    EnabledBySetting=WebRTCEncodedTransform,
    3131    Exposed=Window,
    3232    ImplementedBy=RTCRtpSenderWithTransform,

  • trunk/Source/WebCore/Modules/mediastream/RTCTransformEvent.idl

    r282416 r282523  
    2525[
    2626    Conditional=WEB_RTC,
    27     EnabledBySetting=WebRTCInsertableStreams,
     27    EnabledBySetting=WebRTCEncodedTransform,
    2828    Exposed=Worker,
    2929    InterfaceName=RTCTransformEvent,

  • trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl

    r282416 r282523  
    4747
    4848[Conditional=OFFSCREEN_CANVAS_IN_WORKERS, EnabledAtRuntime=OffscreenCanvasInWorkers] DedicatedWorkerGlobalScope includes AnimationFrameProvider;
    49 [Conditional=WEB_RTC, EnabledBySetting=WebRTCInsertableStreams] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
     49[Conditional=WEB_RTC, EnabledBySetting=WebRTCEncodedTransform] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
Note: See TracChangeset for help on using the changeset viewer.