Changeset 282561 in webkit

Timestamp:

Sep 16, 2021 11:07:01 AM (3 years ago)

Author:

fpizlo@apple.com

Message:

Stub out the footprint() API when libpas is in use
​https://bugs.webkit.org/show_bug.cgi?id=230362

Reviewed by Yusuke Suzuki.

The Gigacage's footprint API is called from some test-only code in JSC, evidently to no
meaningful effect. It's possible for libpas to support such an API but it currently
doesn't. So, stub it out. To my knowledge we don't actually use this API for anything
other than tests, and even tests seem to use it only in the sense that they expect to be
able to call it without crashing.

• bmalloc/Gigacage.cpp:

(Gigacage::footprint):

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• bmalloc/Gigacage.cpp (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2021-09-16  Filip Pizlo  <fpizlo@apple.com>
+
+        Stub out the footprint() API when libpas is in use
+        https://bugs.webkit.org/show_bug.cgi?id=230362
+
+        Reviewed by Yusuke Suzuki.
+
+        The Gigacage's footprint API is called from some test-only code in JSC, evidently to no
+        meaningful effect. It's possible for libpas to support such an API but it currently
+        doesn't. So, stub it out. To my knowledge we don't actually use this API for anything
+        other than tests, and even tests seem to use it only in the sense that they expect to be
+        able to call it without crashing.
+
+        * bmalloc/Gigacage.cpp:
+        (Gigacage::footprint):
+
 2021-09-09  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/bmalloc/bmalloc/Gigacage.cpp

@@ -324 +324 @@
 size_t footprint(Kind kind)
 {
+#if BUSE(LIBPAS)
+    BUNUSED(kind);
+    return 0;
+#else
     return PerProcess<PerHeapKind<Heap>>::get()->at(heapKind(kind)).footprint();
+#endif
 }