Changeset 283282 in webkit

Timestamp:

Sep 29, 2021, 4:53:31 PM (5 years ago)

Author:

basuke.suzuki@sony.com

Message:

[webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
​https://bugs.webkit.org/show_bug.cgi?id=230995

Reviewed by Jonathan Bedard.

LOG_CHANNEL is the macro which is defined in each framework to define list of all channels
in the framework.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_identifier_name_in_declaration):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-09-29  Basuke Suzuki  <basuke.suzuki@sony.com>
+
+        [webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
+        https://bugs.webkit.org/show_bug.cgi?id=230995
+
+        Reviewed by Jonathan Bedard.
+
+        LOG_CHANNEL is the macro which is defined in each framework to define list of all channels
+        in the framework.
+
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_identifier_name_in_declaration):
+
 2021-09-29  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py

@@ -4105 +4105 @@
                 and not modified_identifier == "vm_throw"
                 and not modified_identifier == "DFG_OPERATION"
+                and not modified_identifier == "LOG_CHANNEL"
                 and not modified_identifier.find('chrono_literals') >= 0):
                 error(line_number, 'readability/naming/underscores', 4, identifier + " is incorrectly named. Don't use underscores in your identifier names.")