Changeset 283287 in webkit

Timestamp:

Sep 29, 2021, 5:21:20 PM (5 years ago)

Author:

basuke.suzuki@sony.com

Message:

Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
​https://bugs.webkit.org/show_bug.cgi?id=230963

Reviewed by Mark Lam.

Source/JavaScriptCore:

Added default copy constructor to suppress warning.

• bytecode/Operands.h:

Source/WebCore:

No new tests because there is no behavior change.

Added default copy constructor / copy assignment operator to suppress warning.

• platform/LayoutUnit.h:
• platform/LengthBox.h:
• platform/RectEdges.h:
• platform/graphics/FontSelectionAlgorithm.h:
• platform/graphics/ImagePaintingOptions.h:

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/bytecode/Operands.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/LayoutUnit.h (modified) (2 diffs)
• WebCore/platform/LengthBox.h (modified) (1 diff)
• WebCore/platform/RectEdges.h (modified) (1 diff)
• WebCore/platform/graphics/FontSelectionAlgorithm.h (modified) (1 diff)
• WebCore/platform/graphics/ImagePaintingOptions.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-09-29  Basuke Suzuki  <basuke.suzuki@sony.com>
+
+        Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
+        https://bugs.webkit.org/show_bug.cgi?id=230963
+
+        Reviewed by Mark Lam.
+
+        Added default copy constructor to suppress warning.
+
+        * bytecode/Operands.h:
+
 2021-09-29  Basuke Suzuki  <basuke.suzuki@sony.com>
 

trunk/Source/JavaScriptCore/bytecode/Operands.h

@@ -69 +69 @@
     static Operand tmp(uint32_t index) { return Operand(OperandKind::Tmp, index); }
 
+    Operand& operator=(const Operand&) = default;
+
     OperandKind kind() const { return m_kind; }
     int value() const { return m_operand; }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-29  Basuke Suzuki  <basuke.suzuki@sony.com>
+
+        Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
+        https://bugs.webkit.org/show_bug.cgi?id=230963
+
+        Reviewed by Mark Lam.
+
+        No new tests because there is no behavior change.
+
+        Added default copy constructor / copy assignment operator to suppress warning.
+
+        * platform/LayoutUnit.h:
+        * platform/LengthBox.h:
+        * platform/RectEdges.h:
+        * platform/graphics/FontSelectionAlgorithm.h:
+        * platform/graphics/ImagePaintingOptions.h:
+
 2021-09-29  Kiet Ho  <tho22@apple.com>
 

trunk/Source/WebCore/platform/LayoutUnit.h

@@ -66 +66 @@
 public:
     LayoutUnit() : m_value(0) { }
+    LayoutUnit(const LayoutUnit&) = default;
     LayoutUnit(int value) { setValue(value); }
     LayoutUnit(unsigned short value) { setValue(value); }
@@ -86 +87 @@
     }
 
-    LayoutUnit& operator=(const LayoutUnit& other) = default;
+    LayoutUnit& operator=(const LayoutUnit&) = default;
     LayoutUnit& operator=(const float& other) { return *this = LayoutUnit(other); }
 

trunk/Source/WebCore/platform/LengthBox.h

@@ -56 +56 @@
 
     LengthBox(const LengthBox&) = default;
+    LengthBox& operator=(const LengthBox&) = default;
 
     bool isZero() const

trunk/Source/WebCore/platform/RectEdges.h

@@ -47 +47 @@
 
     RectEdges(const RectEdges&) = default;
+    RectEdges& operator=(const RectEdges&) = default;
 
     template<typename U>

trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h

@@ -427 +427 @@
     using Range = FontSelectionRange;
 
+    FontSelectionCapabilities() = default;
+    FontSelectionCapabilities(const FontSelectionCapabilities&) = default;
     FontSelectionCapabilities& operator=(const FontSelectionCapabilities&) = default;
 

trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h

@@ -48 +48 @@
     ImagePaintingOptions() = default;
     ImagePaintingOptions(const ImagePaintingOptions&) = default;
+    ImagePaintingOptions& operator=(const ImagePaintingOptions&) = default;
 
     CompositeOperator compositeOperator() const { return m_compositeOperator; }