Changeset 283309 in webkit

Timestamp:

Sep 30, 2021, 5:47:30 AM (5 years ago)

Author:

eocanha@igalia.com

Message:

[MSE][GStreamer] Allow infinite duration on MSE
​https://bugs.webkit.org/show_bug.cgi?id=231017

Reviewed by Alicia Boya Garcia.

Source/WebCore:

Positive infinite duration isn't properly working on MSE in the glib (GStreamer) ports. When
such a duration is set, nothing happens and the default zero duration remains. This can break
some live streams, because the wrong duration has influence in the real seek target time
used[1], so the seek may end up being done to the wrong time (before the buffered ranges in
my case) and the playback never starts.

[1] ​https://github.com/WebKit/WebKit/blob/a12c487/Source/WebCore/html/HTMLMediaElement.cpp#L3153

Covered by existing tests.

• platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp:

(WebCore::MediaSourcePrivateGStreamer::durationChanged): Don't discard the change on infinite duration.

LayoutTests:

• platform/glib/TestExpectations: mediasource-seekable.html now passes.
• platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt: Changed expectations because this test now passes for audio/mpeg <-> audio/mpeg.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/glib/TestExpectations (modified) (1 diff)
• LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-09-30  Enrique Ocaña González  <eocanha@igalia.com>
+
+        [MSE][GStreamer] Allow infinite duration on MSE
+        https://bugs.webkit.org/show_bug.cgi?id=231017
+
+        Reviewed by Alicia Boya Garcia.
+
+        * platform/glib/TestExpectations: mediasource-seekable.html now passes.
+        * platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt: Changed expectations because this test now passes for audio/mpeg <-> audio/mpeg.
+
 2021-09-30  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/platform/glib/TestExpectations

@@ -2259 +2259 @@
 
 webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-sequencemode-append-buffer.html [ Failure ]
-webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-seekable.html [ Failure ]
 webkit.org/b/197711 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Pass Timeout Failure ]
 webkit.org/b/214349 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html [ Crash Failure Pass ]

trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt

@@ -5 +5 @@
 PASS Test audio-only implicit changeType for audio/mp4; codecs="mp4a.40.2" <-> audio/mp4; codecs="mp4a.40.2"
 PASS Test audio-only implicit changeType for audio/mp4; codecs="mp4a.40.2" <-> audio/mp4; codecs="mp4a.40.2" (using types without codecs parameters for addSourceBuffer)
-FAIL Test audio-only implicit changeType for audio/mpeg <-> audio/mpeg assert_less_than: expected a number less than 0 but got 2.1
+PASS Test audio-only implicit changeType for audio/mpeg <-> audio/mpeg
 PASS Test video-only implicit changeType for video/webm; codecs="vp8" <-> video/webm; codecs="vp8"
 PASS Test video-only implicit changeType for video/webm; codecs="vp8" <-> video/webm; codecs="vp8" (using types without codecs parameters for addSourceBuffer)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-30  Enrique Ocaña González  <eocanha@igalia.com>
+
+        [MSE][GStreamer] Allow infinite duration on MSE
+        https://bugs.webkit.org/show_bug.cgi?id=231017
+
+        Reviewed by Alicia Boya Garcia.
+
+        Positive infinite duration isn't properly working on MSE in the glib (GStreamer) ports. When
+        such a duration is set, nothing happens and the default zero duration remains. This can break
+        some live streams, because the wrong duration has influence in the real seek target time
+        used[1], so the seek may end up being done to the wrong time (before the buffered ranges in
+        my case) and the playback never starts.
+
+        [1] https://github.com/WebKit/WebKit/blob/a12c487/Source/WebCore/html/HTMLMediaElement.cpp#L3153
+
+        Covered by existing tests.
+
+        * platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp:
+        (WebCore::MediaSourcePrivateGStreamer::durationChanged): Don't discard the change on infinite duration.
+
 2021-09-30  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp

@@ -107 +107 @@
     MediaTime duration = m_mediaSource->duration();
     GST_TRACE("duration: %f", duration.toFloat());
-    if (!duration.isValid() || duration.isPositiveInfinite() || duration.isNegativeInfinite())
+    if (!duration.isValid() || duration.isNegativeInfinite())
         return;