⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 283342 in webkit


Ignore:
Timestamp:
Sep 30, 2021, 3:42:17 PM (5 years ago)
Author:
wilander@apple.com
Message:

PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
​https://bugs.webkit.org/show_bug.cgi?id=230914
<rdar://problem/83639923>

Reviewed by Brent Fulgham.

This patch changes Private Click Measurement's WebIDL attributes from
all lowercase to camelcase to match the spec and align with the
Attribution Reporting API proposal.

References

Source/WebCore:

Existing tests updated.

  • html/HTMLAnchorElement.idl:

LayoutTests:

  • http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt:
  • http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html:
  • http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r283321 r283342  
     12021-09-30  John Wilander  <wilander@apple.com>
     2
     3        PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
     4        https://bugs.webkit.org/show_bug.cgi?id=230914
     5        <rdar://problem/83639923>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        This patch changes Private Click Measurement's WebIDL attributes from
     10        all lowercase to camelcase to match the spec and align with the
     11        Attribution Reporting API proposal.
     12
     13        References
     14        - Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
     15        - Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor
     16
     17        * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt:
     18        * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html:
     19        * http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html:
     20
    1212021-09-30  Ziran Sun  <zsun@igalia.com>
    222

  • trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt

    r275046 r283342  
    1 Test for the new private click measurement attributes on anchor tags.
     1Test for private click measurement attributes on anchor tags.
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    44
    55
    6 PASS anchorTag.attributionsourceid is 40
    7 PASS anchorTag.attributiondestination is "https://destination.example"
     6PASS anchorTag.attributionSourceId is 40
     7PASS anchorTag.attributionDestination is "https://destination.example"
    88PASS successfullyParsed is true
    99

  • trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html

    r275046 r283342  
    88<a id="testTag" href="http://localhost:8000" attributionsourceid=40 attributiondestination="https://destination.example"></a>
    99<script>
    10     description("Test for the new private click measurement attributes on anchor tags.");
     10    description("Test for private click measurement attributes on anchor tags.");
    1111
    1212    const anchorTag = document.getElementById("testTag");
    13     shouldBeEqualToNumber("anchorTag.attributionsourceid", 40);
    14     shouldBeEqualToString("anchorTag.attributiondestination", "https://destination.example");
     13    shouldBeEqualToNumber("anchorTag.attributionSourceId", 40);
     14    shouldBeEqualToString("anchorTag.attributionDestination", "https://destination.example");
    1515</script>
    1616</body>

  • trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html

    r275046 r283342  
    2626        anchorElement.classList.add("wide-link");
    2727        if (sourceID !== null)
    28             anchorElement.attributionsourceid = sourceID;
     28            anchorElement.attributionSourceId = sourceID;
    2929        if (destination !== null)
    30             anchorElement.attributiondestination = destination;
     30            anchorElement.attributionDestination = destination;
    3131        anchorElement.href = "#";
    3232        anchorElement.innerText = "Link" + currentTest;

  • trunk/Source/WebCore/ChangeLog

    r283340 r283342  
     12021-09-30  John Wilander  <wilander@apple.com>
     2
     3        PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
     4        https://bugs.webkit.org/show_bug.cgi?id=230914
     5        <rdar://problem/83639923>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        This patch changes Private Click Measurement's WebIDL attributes from
     10        all lowercase to camelcase to match the spec and align with the
     11        Attribution Reporting API proposal.
     12
     13        References
     14        - Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
     15        - Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor
     16
     17        Existing tests updated.
     18
     19        * html/HTMLAnchorElement.idl:
     20
    1212021-09-30  Rob Buis  <rbuis@igalia.com>
    222

  • trunk/Source/WebCore/html/HTMLAnchorElement.idl

    r275046 r283342  
    2222    Exposed=Window
    2323] interface HTMLAnchorElement : HTMLElement {
    24     [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute unsigned long attributionsourceid;
    25     [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute DOMString attributiondestination;
    26     [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurementFraudPrevention, Reflect] attribute DOMString attributionsourcenonce;
     24    [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute unsigned long attributionSourceId;
     25    [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute DOMString attributionDestination;
     26    [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurementFraudPrevention, Reflect] attribute DOMString attributionSourceNonce;
    2727    [CEReactions=NotNeeded, Reflect] attribute DOMString charset;
    2828    [CEReactions=NotNeeded, Reflect] attribute DOMString coords;
Note: See TracChangeset for help on using the changeset viewer.