Changeset 283348 in webkit

Timestamp:

Sep 30, 2021, 5:26:28 PM (5 years ago)

Author:

ysuzuki@apple.com

Message:

Upgrade GCC requirement to 8.3.0
​https://bugs.webkit.org/show_bug.cgi?id=231042

Reviewed by Darin Adler.

.:

Based on the roadmap[1], we upgrade GCC requirement to 8.3.0, which is default GCC in Debian one-old-stable (buster) right now.
This paves the way to enabling some of useful C++20 features, e.g. default initializer for bitfields.

[1]: ​https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement

• Source/cmake/WebKitCommon.cmake:

Source/JavaScriptCore:

• runtime/ConfigFile.cpp:

(JSC::ConfigFile::canonicalizePaths):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/ConfigFile.cpp (modified) (1 diff)
• Source/cmake/WebKitCommon.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2021-09-30  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Upgrade GCC requirement to 8.3.0
+        https://bugs.webkit.org/show_bug.cgi?id=231042
+
+        Reviewed by Darin Adler.
+
+        Based on the roadmap[1], we upgrade GCC requirement to 8.3.0, which is default GCC in Debian one-old-stable (buster) right now.
+        This paves the way to enabling some of useful C++20 features, e.g. default initializer for bitfields.
+
+        [1]: https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement
+
+        * Source/cmake/WebKitCommon.cmake:
+
 2021-09-29  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-09-30  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Upgrade GCC requirement to 8.3.0
+        https://bugs.webkit.org/show_bug.cgi?id=231042
+
+        Reviewed by Darin Adler.
+
+        * runtime/ConfigFile.cpp:
+        (JSC::ConfigFile::canonicalizePaths):
+
 2021-09-30  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/runtime/ConfigFile.cpp

@@ -488 +488 @@
                 if (shouldAddPathSeparator)
                     strncat(filenameBuffer, "/", 2); // Room for '/' plus NUL
-#if COMPILER(GCC)
-#if GCC_VERSION_AT_LEAST(8, 0, 0)
-                IGNORE_WARNINGS_BEGIN("stringop-truncation")
-#endif
-#endif
+                IGNORE_GCC_WARNINGS_BEGIN("stringop-truncation")
                 strncat(filenameBuffer, m_filename, sizeof(filenameBuffer) - strlen(filenameBuffer) - 1);
-#if COMPILER(GCC)
-#if GCC_VERSION_AT_LEAST(8, 0, 0)
-                IGNORE_WARNINGS_END
-#endif
-#endif
+                IGNORE_GCC_WARNINGS_END
                 strncpy(m_filename, filenameBuffer, s_maxPathLength);
                 m_filename[s_maxPathLength] = '\0';

trunk/Source/cmake/WebKitCommon.cmake

@@ -64 +64 @@
 
     if (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU")
-        if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "7.3.0")
-            message(FATAL_ERROR "GCC 7.3 or newer is required to build WebKit. Use a newer GCC version or Clang.")
+        if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "8.3.0")
+            message(FATAL_ERROR "GCC 8.3 or newer is required to build WebKit. Use a newer GCC version or Clang.")
         endif ()
     endif ()