Changeset 283360 in webkit

Timestamp:

Oct 1, 2021, 2:10:30 AM (5 years ago)

Author:

svillar@igalia.com

Message:

Clamp negative offset values
​https://bugs.webkit.org/show_bug.cgi?id=230707

Reviewed by Simon Fraser.

ScrollOffsets are the values used by scrollbars and thus should be always positive. Under some circumstances
the value returned by maximumScrollOffset()|minimumScrollOffset() could be negative. For those cases we should
just clamp them to zero.

• page/scrolling/ScrollSnapOffsetsInfo.cpp:

(WebCore::updateSnapOffsetsForScrollableArea):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/ScrollSnapOffsetsInfo.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-30  Sergio Villar Senin  <svillar@igalia.com>
+
+        Clamp negative offset values
+        https://bugs.webkit.org/show_bug.cgi?id=230707
+
+        Reviewed by Simon Fraser.
+
+        ScrollOffsets are the values used by scrollbars and thus should be always positive. Under some circumstances
+        the value returned by maximumScrollOffset()|minimumScrollOffset() could be negative. For those cases we should
+        just clamp them to zero.
+
+        * page/scrolling/ScrollSnapOffsetsInfo.cpp:
+        (WebCore::updateSnapOffsetsForScrollableArea):
+
 2021-10-01  Kevin Turner  <kevin_turner@apple.com>
 

trunk/Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp

@@ -306 +306 @@
 
     auto maxScrollOffset = scrollableArea.maximumScrollOffset();
+    maxScrollOffset.clampNegativeToZero();
     auto scrollPosition = LayoutPoint { scrollableArea.scrollPosition() };